[HOLD for payment 2024-12-20] Investigate useOnyx infinite loading state related to the Connection Manager

[fabioh8010]

This issue was first noticed here -> #49509.

I recently implemented a fix in Onyx to solve the infinite loading states after a Onyx.clear() operation, but in this case they are happening without the clear operation, so we must investigate it again.

Report of the problem: #49509 (comment)
Reproducible steps: #49509 (comment)
My initial investigations: #49509 (comment)

[fabioh8010]

Hi @gijoe0295 Could you confirm for me if you are still being able to reproduce this loading state issue? I'm having difficulties to reproduce it. If you are able could you give me the detailed test steps again? Thanks

[fabioh8010]

@ishpaul777 maybe you can help me here with reproducing the problem from your side? We need to remove reuseConnection: false from src/pages/workspace/withPolicy.tsx before testing.

[ishpaul777]

I'll check a confirm in few hours

[ishpaul777]

Tried multiple times, no luck reproducing this is resolved mysteriously

Screen.Recording.2024-12-01.at.10.10.10.PM.mov

[fabioh8010]

@ishpaul777 Should we close this issue then? I asked @kubabutkiewicz to help me with testing and he wasn't able to reproduce it too.

[fabioh8010]

However we can try removing reuseConnection: false from withPolicy and see if a regression will occur from that. WDYT?

[ishpaul777]

However we can try removing reuseConnection: false from withPolicy and see if a regression will occur from that. WDYT?

yes i think that should be a good next step forward 👍

[fabioh8010]

Update: Created a WIP Draft PR. Will proceed with testing soon.

[fabioh8010]

@ishpaul777 PR open to review!

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[fabioh8010]

PR was merged!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Remove reuseConnection from withPolicy #53597

If no regressions arise, payment will be issued on 2024-12-20. 🎊