-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-29] Web - Onboarding task - Old copy Click your profile photo displayed for accounting task #52760
Comments
Triggered auto assignment to @muttmuure ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Old copy Click your profile photo displayed for accounting task What is the root cause of that problem?we are not updating the old copy here Line 5008 in f77087f
What changes do you think we should make in order to solve the problem?We should change the copy from We should check for other places where the old copy might not updated too. What alternative solutions did you explore? (Optional) |
cc @trjExpensify seems like we missed one spot |
Howwwwwwwww! |
Hm, why isn't that one in the Const file? Line 137 in 7bfb345
|
Oh, it is.. but it's "Click your profile photo" not "Click your profile picture" like the others were... 🙄 Line 5037 in 7bfb345
|
Sent a PR. #52808 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-29. 🎊 |
@mountiny @trjExpensify @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@trjExpensify do you want to handle the checklist here? I dont think we need regression tests |
Agreed, all good! Copy change and can be closed. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.64.0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52653
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The first step in the task description should be "Click the settings tab"
Actual Result:
The old copy "Click your profile photo" is displayed in the first step in the task description
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6669113_1731996668025.Recording__970.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @trjExpensifyThe text was updated successfully, but these errors were encountered: