Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-29] Web - Onboarding task - Old copy Click your profile photo displayed for accounting task #52760

Closed
1 of 8 tasks
IuliiaHerets opened this issue Nov 19, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.64.0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #52653
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/and log with a new account
  2. Select "Manage my team's expenses" on the onboarding modal
  3. Select any number of employees
  4. On the the last step select any integration
  5. In the Concierge chat and open the task to connect accounting software

Expected Result:

The first step in the task description should be "Click the settings tab"

Actual Result:

The old copy "Click your profile photo" is displayed in the first step in the task description

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6669113_1731996668025.Recording__970.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@etCoderDysto
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Old copy Click your profile photo displayed for accounting task

What is the root cause of that problem?

we are not updating the old copy here

App/src/CONST.ts

Line 5008 in f77087f

'1. Click your profile photo.\n' +

What changes do you think we should make in order to solve the problem?

We should change the copy from Click your profile photo.\n' to Click the settings tab.\n'

We should check for other places where the old copy might not updated too.

What alternative solutions did you explore? (Optional)

@mountiny
Copy link
Contributor

cc @trjExpensify seems like we missed one spot

@trjExpensify
Copy link
Contributor

Howwwwwwwww!

@trjExpensify
Copy link
Contributor

Hm, why isn't that one in the Const file?

'1. Click the settings tab.\n' +

@trjExpensify
Copy link
Contributor

Oh, it is.. but it's "Click your profile photo" not "Click your profile picture" like the others were... 🙄

App/src/CONST.ts

Line 5037 in 7bfb345

'1. Click your profile photo.\n' +

@trjExpensify trjExpensify assigned mountiny and unassigned muttmuure Nov 20, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 20, 2024
@trjExpensify
Copy link
Contributor

Sent a PR. #52808

@trjExpensify trjExpensify moved this to In Progress in [#whatsnext] #convert Nov 20, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 22, 2024
@melvin-bot melvin-bot bot changed the title Web - Onboarding task - Old copy Click your profile photo displayed for accounting task [HOLD for payment 2024-11-29] Web - Onboarding task - Old copy Click your profile photo displayed for accounting task Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-29. 🎊

Copy link

melvin-bot bot commented Nov 22, 2024

@mountiny @trjExpensify @mountiny The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

@trjExpensify do you want to handle the checklist here? I dont think we need regression tests

@trjExpensify
Copy link
Contributor

Agreed, all good! Copy change and can be closed.

@github-project-automation github-project-automation bot moved this from In Progress to Done in [#whatsnext] #convert Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

5 participants