Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Held expense is lost when individual partially pay the report #52764

Closed
4 of 8 tasks
IuliiaHerets opened this issue Nov 19, 2024 · 37 comments
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 19, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5238586&group_by=cases:section_id&group_id=309128&group_order=asc
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

  1. User A creates 2 expenses to User B
  2. User B opens the report and hold the first expense
  3. User B pay elsewhere partially the report
  4. User A and User B go to the main chat

Expected Result:

Held expense should be present at the bottom of the page

Actual Result:

Held expense disappears for User A. User A must switch chats for the held expense to reappear

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6669335_1732012696842.Recording__4545.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859644564044218290
  • Upwork Job ID: 1859644564044218290
  • Last Price Increase: 2024-12-26
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sonialiap sonialiap added the External Added to denote the issue can be worked on by a contributor label Nov 21, 2024
@melvin-bot melvin-bot bot changed the title Hold - Held expense is lost when individual partially pay the report [$250] Hold - Held expense is lost when individual partially pay the report Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021859644564044218290

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

@melvin-bot melvin-bot bot removed the Overdue label Nov 21, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@suneox, @sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
@suneox
Copy link
Contributor

suneox commented Nov 25, 2024

We’re still looking for proposals

@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@jacobkim9881
Copy link
Contributor

It's not reproducible.

@suneox
Copy link
Contributor

suneox commented Nov 26, 2024

It's not reproducible.

@jacobkim9881 Thanks for your feedback.
This issue can not reproduce on latest staging so we can retest then close this issue

Screen.Recording.2024-11-26.at.22.16.52.mp4

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 26, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@jacobkim9881
Copy link
Contributor

@suneox Thanks for reviewing. Let me check my solution.

@suneox
Copy link
Contributor

suneox commented Dec 2, 2024

The issue is not reproducible. Waiting for retest and close

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 5, 2024

@suneox, @sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2024
@sonialiap sonialiap added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label Dec 5, 2024
@sonialiap
Copy link
Contributor

added the retest label

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2024
@sonialiap sonialiap changed the title [$250] Hold - Held expense is lost when individual partially pay the report [$250] Held expense is lost when individual partially pay the report Dec 13, 2024
@sonialiap
Copy link
Contributor

I'm OOO Dec 16-20 but I don't think this will need a BZ while I'm out so not adding a leave buddy

@shubham1206agra
Copy link
Contributor

Internal issue as this requires Pusher updates to be sent correctly.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@shubham1206agra
Copy link
Contributor

@suneox Fastracked the review for you

@suneox
Copy link
Contributor

suneox commented Dec 13, 2024

@suneox Fastracked the review for you

I'd like to confirmed that this issue can reproducible at step 3.

Screen.Recording.2024-12-13.at.22.44.39.mp4

It doesn’t occur at step 4, so I think we should remove step 4 from the action performed.

Screen.Recording.2024-12-13.at.22.55.16.mp4

@melvin-bot melvin-bot bot added the Overdue label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 17, 2024

@suneox @sonialiap @thienlnam this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@suneox
Copy link
Contributor

suneox commented Dec 17, 2024

We're still looking for proposals on this issue. I’ve posted it to Slack to get more attention

@melvin-bot melvin-bot bot removed the Overdue label Dec 17, 2024
Copy link

melvin-bot bot commented Dec 17, 2024

@suneox, @sonialiap, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Dec 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2024
Copy link

melvin-bot bot commented Dec 20, 2024

@suneox, @sonialiap, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@sonialiap
Copy link
Contributor

@suneox Shubham mentioned here #52764 (comment) that this may be internal, what do you think?

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
@suneox
Copy link
Contributor

suneox commented Dec 25, 2024

@suneox Shubham mentioned here #52764 (comment) that this may be internal, what do you think?

This issue is not reproducible during KI retests, so we can wait until next week to reassess.

Copy link

melvin-bot bot commented Dec 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
@shubham1206agra
Copy link
Contributor

@suneox Can we close this?

@suneox
Copy link
Contributor

suneox commented Dec 30, 2024

@suneox Can we close this?

Yes we can close this one

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 30, 2024
Copy link

melvin-bot bot commented Jan 2, 2025

@suneox, @sonialiap, @thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 2, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

8 participants