[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN #52775

IuliiaHerets · 2024-11-19T15:04:06Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 9.0.64-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5242214&group_by=cases:section_id&group_order=asc&group_id=229064
Issue reported by: Applause Internal Team

Action Performed:

Open the Expensify app.
Open any group chat.
Tap on the header and select "Members"
Remove members from the group.
Verify a system message is displayed showing this action and that the same message is seen on chat preview.
Tap on "Settings" on the bottom of the page.
Tap on "Preferences" and select "Language"
Change language to Spanish.
Return to inbox and verify that the preview of the group chat was updated to this change, and the system message on chat too.

Expected Result:

When changing language to spanish, the system message showing the action of removing group members and the preview of the chat on LHN, should be updated to this change.

Actual Result:

Message about removed members of a group in chat preview on LHN, is not updated to the language change.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6669579_1732026214491.Removed.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859794304218279153
Upwork Job ID: 1859794304218279153
Last Price Increase: 2024-12-06
Automatic offers:

mkzie2 | Contributor | 105230840

Issue Owner

Current Issue Owner: @stephanieelliott

melvin-bot · 2024-11-19T15:04:15Z

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

mkzie2 · 2024-11-19T15:30:01Z

Edited by proposal-police: This proposal was edited at 2024-12-04 03:51:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Message about removed members of a group in chat preview on LHN, is not updated to the language change.

What is the root cause of that problem?

We already have a case for REMOVEFROMROOM action with isInviteOrRemovedAction check here.

App/src/libs/SidebarUtils.ts

Lines 437 to 439 in 9268594

    
           } else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) { 
        
               const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null; 
        
               const targetAccountIDs = lastActionOriginalMessage?.targetAccountIDs ?? [];

But the group chat report doesn't move to this block because this condition here

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

    
           if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

What changes do you think we should make in order to solve the problem?

We should add a case for a group chat report here

const isGroupChat = ReportUtils.isGroupChat(report) || ReportUtils.isDeprecatedGroupDM(report);
if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage || isGroupChat) && !result.private_isArchived) {

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

    
           if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

What alternative solutions did you explore? (Optional)

FitseTLT · 2024-11-19T16:31:42Z

Edited by proposal-police: This proposal was edited at 2024-11-19 16:29:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Preferences - When changing language, message about removed users is not changed in LHN

What is the root cause of that problem?

We are displaying a properly constructed and translated text in ReportActionItemMessage here

App/src/pages/home/report/ReportActionItemMessage.tsx

Line 45 in 14ca237

if (ReportActionsUtils.isMemberChangeAction(action)) {

But we have forgotten to make the same translation in two places by handling isInviteOrRemovedAction case specifically

In LHN: Although we are handling the case for isInviteOrRemovedAction here

App/src/libs/SidebarUtils.ts

Lines 437 to 438 in 14ca237

    
           } else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) { 
        
               const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null;

It will not reach it as we haven't included isGroupChat condition here

App/src/libs/SidebarUtils.ts

Line 430 in 14ca237

    
           if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

In chat thread header title: if we create a thread with the removed system action the chat thread report header title will not have the proper translated text matching with the report action itself as we didn't handle the case in getReportName here as we did for other exceptional report action cases

App/src/libs/ReportUtils.ts

Line 4006 in 14ca237

if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {

What changes do you think we should make in order to solve the problem?

We can add the isGroupChat condition in here but I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats so we should add isGroupChat condition and only for this specific case of isInviteOrRemovedAction here

App/src/libs/SidebarUtils.ts

Line 430 in 14ca237

if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

...
result.isTaskReport ||
            ((ReportUtils.isGroupChat(report) || ReportUtils.isDeprecatedGroupDM(report)) && ReportActionsUtils.isInviteOrRemovedAction(lastAction)) ||
            isThreadMessage)
...

But if we are ok with passing through the code section we will also need to move the code that precedes it with lastActorDisplayName for group chat case from here to here
2. We should handle the isInviteOrRemovedAction in getReportName here

App/src/libs/ReportUtils.ts

Line 4006 in 14ca237

    
           if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isModifiedExpenseAction(parentReportAction)) {

 if (!isEmptyObject(parentReportAction) && ReportActionsUtils.isMemberChangeAction(parentReportAction)) {
            const elemets = ReportActionsUtils.getMemberChangeMessageElements(parentReportAction);
            const actionMessage = elemets.map((element) => element.content).join('');
            return formatReportLastMessageText(actionMessage);
        }

we can also optionally parse Parser.htmlToText what is returned from ReportActionsUtils.getMemberChangeMessageFragment(action).html

What alternative solutions did you explore? (Optional)

stephanieelliott · 2024-11-22T03:01:21Z

Tested and confirmed that the language on system messages should update

melvin-bot · 2024-11-22T03:01:31Z

Job added to Upwork: https://www.upwork.com/jobs/~021859794304218279153

melvin-bot · 2024-11-22T03:01:35Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

dukenv0307 · 2024-11-24T09:09:15Z

@mkzie2

and handle this case here

Why do we need to handle this case here? If we move isGroupChat to if block, it will be false in else block. Please correct me if I miss sth

@FitseTLT

I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats

Can you show me the reason why we are doing that?

mkzie2 · 2024-11-24T10:40:09Z

@dukenv0307 For group chat, we want to show the lastActorDisplayName with the lastMessageText then we need to update the condition handle this case as well for group chat.

Another note: Add group chat to this case will be safe because some actions are handled the same with getLastMessageTextForReport and some other actions don't exist in group chat

FitseTLT · 2024-11-24T15:16:53Z

@FitseTLT

I don't think we want to allow group chat reports case to pass through the unwanted code section that we are now avoiding currently for group chats

Can you show me the reason why we are doing that?

@dukenv0307 I am not insisting on it, I am just mentioning it as an option as adding only isGroupChat condition might not be desirable to fix problem for one type of action as it will force it to pass through a code section that handles many other types of actions although most of the actions are more or less room and policy related except may be this one

App/src/libs/SidebarUtils.ts

Line 435 in 9268594

} else if (ReportActionsUtils.isTaskAction(lastAction)) {

if we also want the task actions handled similarly for group chats too we are good to go but in that case we will also need to move the code that precedes it with lastActorDisplayName for group chat case from here to here I have updated my proposal with this additional changed needed in case we are ok with passing through the code section 👍
However, the most important thing we should also handle is to fix getReportName as I mentioned in my proposal as without it the chat thread header name will mismatch the report action displayed 👍

melvin-bot · 2024-11-27T09:11:26Z

@stephanieelliott, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot · 2024-11-29T09:26:04Z

@stephanieelliott, @dukenv0307 Eep! 4 days overdue now. Issues have feelings too...

melvin-bot · 2024-11-29T16:00:10Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

dukenv0307 · 2024-11-30T03:03:33Z

will give the update by EOD

dukenv0307 · 2024-11-30T04:26:02Z

@mkzie2 Can we just move the isGroup chat logic to

App/src/libs/SidebarUtils.ts

Line 430 in 9268594

    
           if ((result.isChatRoom || result.isPolicyExpenseChat || result.isThread || result.isTaskReport || isThreadMessage) && !result.private_isArchived) {

For the logic, we already handle it in here

@FitseTLT

as I mentioned in my proposal as without it we would be causing a regression where the chat thread header name will mismatch the report action displayed

I think this bug is out of scope and already happens on staging, not after applying your first point.

Pls correct me if I missed sth.

mkzie2 · 2024-11-30T07:54:56Z

@mkzie2 Can we just move the isGroup chat logic to

@dukenv0307 Checked again and you're correct, we can simply add isGroupChat to this logic.

FitseTLT · 2024-11-30T18:35:01Z

I think this bug is out of scope and already happens on staging, not after applying your first point.

Pls correct me if I missed sth.

Yes it might not be a regression but the root cause of the problem is when they implemented the translation of the report action they only implemented for ReportActionItem and copy to clipboard and LHN (excluding group chat) and forgot for thread header title getReportName and I can't see that out of the scope of this issue and it is closely related to the deep root cause of the issue.

mkzie2 · 2024-12-02T04:53:29Z

I don't think it's in the scope of the issue.

The messages we handle in LHN and the Report screen differ. We're fixing the bug in LHN, not in the Report screen.

I can't see that out of the scope of this issue and it is closely related to the deep root cause of the issue.

Based on the deep root cause, the problem isn't that we don't handle the translation case for this action. We handled it here.

App/src/libs/SidebarUtils.ts

Lines 437 to 439 in 9268594

    
           } else if (ReportActionsUtils.isInviteOrRemovedAction(lastAction)) { 
        
               const lastActionOriginalMessage = lastAction?.actionName ? ReportActionsUtils.getOriginalMessage(lastAction) : null; 
        
               const targetAccountIDs = lastActionOriginalMessage?.targetAccountIDs ?? [];

The RCA is just we don't include the group chat report in this case.

cc @dukenv0307

melvin-bot · 2024-12-03T09:04:27Z

@stephanieelliott @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

melvin-bot · 2024-12-03T09:22:29Z

@stephanieelliott, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

stephanieelliott · 2024-12-04T00:29:49Z

Hey @dukenv0307 what's the next step here, are we still waiting for different proposals?

dukenv0307 · 2024-12-04T03:18:26Z

I think @mkzie2's proposal is good enough to fix the issue

Checked again and you're correct, we can simply add isGroupChat to this logic.

Can you please update your proposal?

For the bug on header we can handle it in other issue, but I need to hear another though from internal team.

mkzie2 · 2024-12-04T03:51:28Z

@dukenv0307 Updated my proposal.

dukenv0307 · 2024-12-04T07:22:40Z

@mkzie2's proposal looks good to me. It's good to fix the issue. For the bug on the thread header here, we should handle it on another issue. Please let me know what's your thoughts?

🎀👀🎀 C+ reviewed

melvin-bot · 2024-12-04T07:22:52Z

Triggered auto assignment to @marcochavezf, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

dukenv0307 · 2024-12-06T11:54:06Z

@marcochavezf can you please take a look at this issue? Thanks

melvin-bot · 2024-12-06T16:00:11Z

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

marcochavezf · 2024-12-06T23:39:25Z

Thanks for the review @dukenv0307, I agree that we can handle the other bug in a different issue, assigning @mkzie2 🚀

melvin-bot · 2024-12-06T23:39:39Z

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

mvtglobally · 2024-12-07T05:09:41Z

Issue not reproducible during KI retests. (First week)

mkzie2 · 2024-12-07T10:11:02Z

@dukenv0307 The PR is here.

melvin-bot · 2024-12-12T01:34:01Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-12-12T01:34:06Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix remove member message in group chat is not translated in LHN #53732

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment through NewDot Manual Requests
@mkzie2 requires payment automatic offer (Contributor)

melvin-bot · 2024-12-12T01:34:07Z

@dukenv0307 @stephanieelliott @dukenv0307 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024

melvin-bot bot assigned stephanieelliott Nov 19, 2024

stephanieelliott added the External Added to denote the issue can be worked on by a contributor label Nov 22, 2024

melvin-bot bot changed the title ~~Preferences - When changing language, message about removed users is not changed in LHN~~ [$250] Preferences - When changing language, message about removed users is not changed in LHN Nov 22, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 22, 2024

melvin-bot bot assigned dukenv0307 Nov 22, 2024

melvin-bot bot added the Overdue label Nov 27, 2024

melvin-bot bot removed the Overdue label Nov 30, 2024

melvin-bot bot added the Overdue label Dec 2, 2024

stephanieelliott added this to [#whatsnext] #expense Dec 4, 2024

melvin-bot bot removed the Overdue label Dec 4, 2024

melvin-bot bot assigned marcochavezf Dec 4, 2024

marcochavezf assigned mkzie2 Dec 6, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 6, 2024

mkzie2 mentioned this issue Dec 7, 2024

Fix remove member message in group chat is not translated in LHN #53732

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 7, 2024

garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 10, 2024

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 12, 2024

melvin-bot bot changed the title ~~[$250] Preferences - When changing language, message about removed users is not changed in LHN~~ [HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN Dec 12, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN #52775

[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN #52775

IuliiaHerets commented Nov 19, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Nov 19, 2024

mkzie2 commented Nov 19, 2024 •

edited by github-actions bot

Loading

FitseTLT commented Nov 19, 2024 •

edited

Loading

stephanieelliott commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

dukenv0307 commented Nov 24, 2024

mkzie2 commented Nov 24, 2024

FitseTLT commented Nov 24, 2024 •

edited

Loading

melvin-bot bot commented Nov 27, 2024

melvin-bot bot commented Nov 29, 2024

melvin-bot bot commented Nov 29, 2024

dukenv0307 commented Nov 30, 2024

dukenv0307 commented Nov 30, 2024

mkzie2 commented Nov 30, 2024

FitseTLT commented Nov 30, 2024 •

edited

Loading

mkzie2 commented Dec 2, 2024

melvin-bot bot commented Dec 3, 2024

melvin-bot bot commented Dec 3, 2024

stephanieelliott commented Dec 4, 2024

dukenv0307 commented Dec 4, 2024

mkzie2 commented Dec 4, 2024

dukenv0307 commented Dec 4, 2024

melvin-bot bot commented Dec 4, 2024

dukenv0307 commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

marcochavezf commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

mvtglobally commented Dec 7, 2024

mkzie2 commented Dec 7, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN #52775

[HOLD for payment 2024-12-19] [$250] Preferences - When changing language, message about removed users is not changed in LHN #52775

Comments

IuliiaHerets commented Nov 19, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Nov 19, 2024

mkzie2 commented Nov 19, 2024 • edited by github-actions bot Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

FitseTLT commented Nov 19, 2024 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

stephanieelliott commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

melvin-bot bot commented Nov 22, 2024

dukenv0307 commented Nov 24, 2024

mkzie2 commented Nov 24, 2024

FitseTLT commented Nov 24, 2024 • edited Loading

melvin-bot bot commented Nov 27, 2024

melvin-bot bot commented Nov 29, 2024

melvin-bot bot commented Nov 29, 2024

dukenv0307 commented Nov 30, 2024

dukenv0307 commented Nov 30, 2024

mkzie2 commented Nov 30, 2024

FitseTLT commented Nov 30, 2024 • edited Loading

mkzie2 commented Dec 2, 2024

melvin-bot bot commented Dec 3, 2024

melvin-bot bot commented Dec 3, 2024

stephanieelliott commented Dec 4, 2024

dukenv0307 commented Dec 4, 2024

mkzie2 commented Dec 4, 2024

dukenv0307 commented Dec 4, 2024

melvin-bot bot commented Dec 4, 2024

dukenv0307 commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

marcochavezf commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

mvtglobally commented Dec 7, 2024

mkzie2 commented Dec 7, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

melvin-bot bot commented Dec 12, 2024

IuliiaHerets commented Nov 19, 2024 •

edited by melvin-bot bot

Loading

mkzie2 commented Nov 19, 2024 •

edited by github-actions bot

Loading

FitseTLT commented Nov 19, 2024 •

edited

Loading

FitseTLT commented Nov 24, 2024 •

edited

Loading

FitseTLT commented Nov 30, 2024 •

edited

Loading