Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Expense - Nothing happens after approving expense and tapping dropdown button #52873

Open
2 of 8 tasks
IuliiaHerets opened this issue Nov 21, 2024 · 12 comments · Fixed by #52901
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #50387
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Add approvals feature is enabled.
  • Admin is the approver.
  1. Launch the app.
  2. Go to workspace chat.
  3. Submit an expense.
  4. Dismiss the keyboard.
  5. Tap Approve.
  6. Tap dropdown button next to pay button.
  7. Might need to repeat Step 3 to 6 a few times.

Expected Result:

Payment option dropdown will open after approving expense and tapping dropdown button.

Actual Result:

Nothing happens after approving expense and tapping dropdown button.

This issue is not reproducible after opening expense thread and tapping dropdown button from the main chat.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6671504_1732175365248.w_02eb86e4e5c6f3c7327221f5b548e945d54e3ad6-2024-11-21_07_47_09.051.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 21, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 21, 2024

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 21, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 21, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mjasikowski
Copy link
Contributor

Checking

@mjasikowski
Copy link
Contributor

can't reproduce in dev

@mjasikowski
Copy link
Contributor

Reproduced this on a real device - Pixel 4a

@mjasikowski
Copy link
Contributor

Creating a revert PR

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Nov 21, 2024
@mjasikowski mjasikowski reopened this Nov 21, 2024
@mjasikowski
Copy link
Contributor

Revert PR pulled, CP request sent to #deployer

@chiragsalian
Copy link
Contributor

Looks like PR has been CP'd removing blocker label.

@DylanDylann
Copy link
Contributor

@mjasikowski Could you please check this comment?

@mjasikowski
Copy link
Contributor

@DylanDylann trying to reproduce it locally again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
5 participants