Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks #52977

Open
danielrvidal opened this issue Nov 22, 2024 · 23 comments
Assignees
Labels
External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@danielrvidal
Copy link
Contributor

danielrvidal commented Nov 22, 2024

Now that we have the two minute tour, we would like to remove the following tasks from the following flows:

  • Remove "Enable your wallet" task from the Get paid back from my employer onboarding tasks
  • Remove "Add personal bank account" from the Chat and split expenses with friends onboarding tasks.

Here is the Get paid back from my employer onboarding tasks:
image

Here are the current Chat and split expenses with friends onboarding tasks
image

Issue OwnerCurrent Issue Owner: @jjcoffee
@danielrvidal danielrvidal added External Added to denote the issue can be worked on by a contributor Daily KSv2 labels Nov 22, 2024
@danielrvidal danielrvidal self-assigned this Nov 22, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 22, 2024
Copy link

melvin-bot bot commented Nov 22, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 22, 2024

Edited by proposal-police: This proposal was edited at 2024-11-22 19:43:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Remove the task here

App/src/CONST.ts

Lines 129 to 132 in ef0d341

type: 'addBankAccount',
autoCompleted: false,
title: 'Add personal bank account',
description:

and here

App/src/CONST.ts

Lines 166 to 170 in ef0d341

{
type: 'addBankAccount',
autoCompleted: false,
title: 'Add personal bank account',
description:

and here

App/src/CONST.ts

Lines 129 to 131 in ef0d341

type: 'addBankAccount',
autoCompleted: false,
title: 'Add personal bank account',

We should fix in the BE as well

What alternative solutions did you explore? (Optional)

@Krishna2323

This comment was marked as off-topic.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 22, 2024

Proposal Updated

  • Minor update

@Kalydosos
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement needed

What changes do you think we should make in order to solve the problem?

  1. "Enable your wallet" is already absent from the tasks of "Get paid back from my employer" onboarding menu. Nothing to do then
  2. To remove "Add personal bank account" from the Chat and split expenses with friends onboarding tasks, we just need to remove here
    https://github.com/Expensify/App/blob/main/src/CONST.ts#L5102-L5116

no BE change needed

RESULT

Capture d’écran de 2024-11-23 16-03-47

What alternative solutions did you explore? (Optional)

None

@anmurali
Copy link

@jjcoffee - can you please review these proposals so we can move forward?

@jjcoffee
Copy link
Contributor

I only see two tasks for Get paid back from my employer (on latest main), Submit an expense and Add personal bank account. There's no Take a 2-minute tour.

image

Could you confirm if we still need to make any changes to Get paid back from my employer? @anmurali or @danielrvidal

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 25, 2024

@jjcoffee Regarding Take a 2-minute tour we have some issues here: #52908 #52985

@jjcoffee
Copy link
Contributor

jjcoffee commented Nov 25, 2024

Thanks @NJ-2020! Looks like the fix has been CP'ed now, but there's still Add personal bank account instead of Enable your wallet.

image

I think you may have made a mistake in your proposal, with the third code block that needs updating (it repeats the first). Can you get that updated?

@jjcoffee
Copy link
Contributor

Assuming the above doesn't change anything regarding what we want to do here, I'm happy to go with @NJ-2020's proposal, as he was first and the general thrust is correct (even if the third code block to update isn't quite right 😉).

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Nov 25, 2024

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 25, 2024

@jjcoffee Ohh, okay thank you, will update that on the PR

@Kalydosos
Copy link
Contributor

@jjcoffee @NJ-2020 mentionned a need to fix the BE, which is not also correct imho

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 25, 2024
@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 26, 2024

Hi, regarding "Get paid back option" may I get the "Enable your wallet" task description please

App/src/CONST.ts

Lines 128 to 134 in bb4c89d

{
type: 'addBankAccount',
autoCompleted: false,
title: 'Add personal bank account',
description:
'You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!\n' +
'\n' +

cc: @danielrvidal @yuwenmemon

@danielrvidal
Copy link
Contributor Author

Why do you need the description for that if we're removing it? I'm not sure I understand. I think we're remove the task and description.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 28, 2024

Ohh sorry about that, I though we need to replace the Add personal bank account with Enable your wallet based on this comment

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
@jjcoffee
Copy link
Contributor

@NJ-2020 No, I just meant that the current behaviour was a bit different from the issue description. We haven't agreed to do anything about it. You can proceed with the PR just dealing with removing the tasks as described in the issue.

@NJ-2020
Copy link
Contributor

NJ-2020 commented Nov 30, 2024

For the recording videos, there's an issue the onboarding doesn't show up when login with new account

Should we wait until the issue got fix, or we can just override the nvp_onboarding value?

cc: @jjcoffee

@jjcoffee
Copy link
Contributor

jjcoffee commented Dec 2, 2024

@NJ-2020 Overriding nvp_onboarding is fine imo.

Copy link

melvin-bot bot commented Dec 2, 2024

@danielrvidal, @yuwenmemon, @jjcoffee, @NJ-2020 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@NJ-2020
Copy link
Contributor

NJ-2020 commented Dec 2, 2024

@jjcoffee Okay thanks

I will be OOO for 1 day

@danielrvidal
Copy link
Contributor Author

All good @NJ-2020 I'm guessing this should be pretty easy so do you think you can have a PR to review by EOD Wed?

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 4, 2024
@NJ-2020
Copy link
Contributor

NJ-2020 commented Dec 4, 2024

PR ready

cc: @jjcoffee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: No status
Development

No branches or pull requests

7 participants