[HOLD for payment 2024-12-07] Debug Mode - "Hmm... it's not here page" is shown when deleting a created violation

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: Can't check on prod as no Debug mode option
Issue was found when executing this PR: #50745
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Enable debug mode in Troubleshoot
3. Open an expense thread (create one if you don't have any)
4. Enter debug view then check on "View transaction" tab
5. Go to "violations" > Create a violation and save it
6. Go to the created violation and delete it.

Expected Result:

Violation is deleted and navigates to the previous page (violation tab).

Actual Result:

"Hmm... it's not here page" is shown.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6673719_1732321381310.Screen_Recording_2024-11-23_at_2.57.06_at_night.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[NJ-2020]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Debug Mode - "Hmm... it's not here page" is shown when deleting a created violation

What is the root cause of that problem?

Offending PR: #50745
We do not invoke the goBack function after we delete the violation

App/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx

Lines 74 to 78 in 3ebe852

	<DebugDetails
	formType={CONST.DEBUG.FORMS.TRANSACTION_VIOLATION}
	data={transactionViolation}
	onSave={saveChanges}
	onDelete={deleteTransactionViolation}

App/src/pages/Debug/TransactionViolation/DebugTransactionViolationPage.tsx

Lines 45 to 49 in 3ebe852

	const deleteTransactionViolation = useCallback(() => {
	const updatedTransactionViolations = [...(transactionViolations ?? [])];
	updatedTransactionViolations.splice(Number(index), 1);
	Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, updatedTransactionViolations);
	}, [index, transactionID, transactionViolations]);

And same here

App/src/pages/Debug/Transaction/DebugTransactionPage.tsx

Lines 60 to 70 in 3ebe852

	<DebugDetails
	formType={CONST.DEBUG.FORMS.TRANSACTION}
	data={transaction}
	onSave={(data) => {
	Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, data);
	}}
	onDelete={() => {
	Debug.setDebugData(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, null);
	}}
	validate={DebugUtils.validateTransactionDraftProperty}
	>

What changes do you think we should make in order to solve the problem?

We should invoke the goBack function after we delete the data same like what we do here

App/src/pages/Debug/ReportAction/DebugReportActionPage.tsx

Lines 60 to 69 in 3ebe852

	<DebugDetails
	formType={CONST.DEBUG.FORMS.REPORT_ACTION}
	data={reportAction}
	onSave={(data) => {
	Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[reportActionID]: data});
	}}
	onDelete={() => {
	Debug.setDebugData(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, {[reportActionID]: null});
	Navigation.goBack();
	}}

Navigation.goBack();

What alternative solutions did you explore? (Optional)

[DylanDylann]

cc @pac-guerreiro

[mountiny]

cc @DylanDylann @pac-guerreiro @puneetlath @fabioh8010 this seems to be coming from your PR. I will demote this as its a debug mode feature related so not a blocker for customers really, but please take a look , thanks!

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[pac-guerreiro]

I just opened a draft PR with the fix -> #53095

[pac-guerreiro]

Today I added test steps and filled my checklist. I need to add screenshots / screen recordings tomorrow.

[pac-guerreiro]

Just added the missing screen recordings. The PR is now ready for review 😄

This next week I'll be off, but someone from my team will take care of any feedback on this PR 😄

[JKobrynski]

Hi, I'm Julian from Callstack and I'm going to work on this issue in Pedro's absence.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Debug Mode - "Hmm... it's not here page" is shown when deleting a created violation #53095

If no regressions arise, payment will be issued on 2024-12-07. 🎊

For reference, here are some details about the assignees on this issue:

• @JKobrynski does not require payment (Contractor)
• @pac-guerreiro does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @slafortune @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @JKobrynski is from an agency-contributor and not due payment
• Contributor: @pac-guerreiro is from an agency-contributor and not due payment
• ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@slafortune)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[puneetlath]

@DylanDylann is this a regression or does this require payment?

[DylanDylann]

This is so minor that we missed it in the previous PR, let's close this issue