Debug - There is no error message when selecting taxAmountChanged violation

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Issue found when executing PR #50745

Action Performed:

1. Navigate to a workspace chat
2. Create a manual request with tax rate
3. Go to Settings > Troubleshoot > enable Debug mode
4. Go back to the IOU you have created on step 2
5. Open the IOU's transaction details page
6. Click on. Header > Debug > View transaction > Violations > Create > Save
7. Open the violation > click on 'name' > select taxAmountChanged > Save
8. Return to the transaction thread

Expected Result:

Tax amount field should display violation

Actual Result:

Tax amount field doesn't display violation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6673923_1732347355690.Screen_Recording_2024-11-23_at_10.22.08_in_the_morning.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JKobrynski

[melvin-bot]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[DylanDylann]

cc @pac-guerreiro

[mountiny]

@pac-guerreiro @DylanDylann please look into this as a regression from your PR

The error message isn't displayed because we excluded taxAmountChanged and taxRateChanged here. Should we filter out two violations when we select the violation name in debug?

this is from @dukenv0307, I think @puneetlath will have better context from the linked PR too

[mountiny]

Not a blocker as this is a debug feature

[mountiny]

also cc @fabioh8010

[pac-guerreiro]

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

[pac-guerreiro]

@lanitochka17 @mountiny @DylanDylann @fabioh8010

It seems that this violation is excluded in NewDot, that's why there's no message displayed:

Should I just exclude it from the name picker in debug mode?

[mountiny]

That would make sense to me

[puneetlath]

Makes sense to me too.

[pac-guerreiro]

I just opened a draft PR with the fix - #53097

[pac-guerreiro]

Today I added test steps and filled my checklist. I need to add screenshots / screen recordings tomorrow.

[pac-guerreiro]

Just added the missing screen recordings. The PR is now ready for review 😄

This next week I'll be off, but someone from my team will take care of any feedback on this PR 😄

[JKobrynski]

Hi, I'm Julian from Callstack and I'm going to work on this issue in Pedro's absence.

[DylanDylann]

@puneetlath We already have a new PR to remove taxAmountChanged and taxRateChanged violations. I think we can close this one

[puneetlath]

Ok sounds good. I've gone ahead and paid you for it since the full review was done before we decided to close.