Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Adding bank account to receive invoice payment is confusing #53032

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 23, 2024 · 14 comments
Closed
1 of 8 tasks

[$250] Adding bank account to receive invoice payment is confusing #53032

m-natarajan opened this issue Nov 23, 2024 · 14 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 23, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.66-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation (hyperlinked to channel name): Expensify-billpay

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a workspace if needed
  3. Go to More features, scroll down and enable Invoices
  4. Click green plus, Send invoice
  5. [User A] Send an invoice to User B
  6. [User B] Go to invoice chat and pay the invoice as business
  7. [User A] Go to invoice report
  8. [User A] Click Add bank account
  9. [User A] Note that the button leads to Invoices on workspace settings
  10. [User A] Click Add bank account and add a bank account
  11. [User A] Go back to workspace chat

Expected Result:

After adding a bank account for the invoice report the user should be navigated back to it, and the add bank account button should be gone. We could potentially have a system message saying that they added a bank account to receive the invoice payment.
Also, maybe instead of directing the the workspace settings after clicking add bank account, we should instead have an informational page at the end of the flow in the RHP that explains the account has been added as the invoice transfer bank account.

Actual Result:

The add bank account button on the invoice report navigates to settings, then after adding it you land back on the settings page and have to manually navigate back to the invoice report. Additionally, the add bank account button will remain present until you go to invoicing settings, click on the overflow menu of the bank account, and make it the default payment method.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
InvoiceConfusing2024-11-22_14-31-39.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021863586879380659008
  • Upwork Job ID: 1863586879380659008
  • Last Price Increase: 2024-12-02
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Nov 23, 2024
Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 23, 2024

Triggered auto assignment to @arosiclair (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added the Weekly KSv2 label Nov 23, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@abzokhattab
Copy link
Contributor

I think this is a dupe of #50474

@m-natarajan m-natarajan removed Weekly KSv2 Needs Reproduction Reproducible steps needed AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Nov 23, 2024
@arosiclair
Copy link
Contributor

Unassigning since this isn't a quality issue

@arosiclair arosiclair removed their assignment Nov 25, 2024
@johncschuster
Copy link
Contributor

Agreed. I think this fits into #expense better. I also think this behavior is expected. I've raised a discussion here to chat about it.

@johncschuster
Copy link
Contributor

Discussion is ongoing

@johncschuster
Copy link
Contributor

Not much chatter in Slack on this one. I've pinged my pal, @garrettmknight to chime in as the project curator 👍

@johncschuster
Copy link
Contributor

Ok! It sounds like we all agree that the expected behavior outlined here is the behavior we want (i.e. when a user gets routed to add a bank account from an invoice, they should be brought back to the invoice after adding the bank account).

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@johncschuster johncschuster added External Added to denote the issue can be worked on by a contributor Overdue labels Dec 2, 2024
@melvin-bot melvin-bot bot changed the title Adding bank account to receive invoice payment is confusing [$250] Adding bank account to receive invoice payment is confusing Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021863586879380659008

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 2, 2024
Copy link

melvin-bot bot commented Dec 2, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@abzokhattab
Copy link
Contributor

is this a different issue from this #50474?

@neil-marcellini neil-marcellini self-assigned this Dec 2, 2024
@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 3, 2024
@johncschuster
Copy link
Contributor

Good shout, @abzokhattab! It does sound like these issues are pretty similar. @neil-marcellini, what do you think?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 4, 2024
@neil-marcellini
Copy link
Contributor

Woops yes I think these are the same thing, it was probably a mistake of mine to create a separate issue. I will close this in favor of the original issue and bring any information from here over there.

@neil-marcellini neil-marcellini closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

7 participants