[HOLD for payment 2025-01-13] [$250] Bulk deleted categories reappear.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation (hyperlinked to channel name): Expensify - Convert

Action Performed:

Be on a slow network 3g

1. Go to workspace setting
2. Select category
3. Bulk select the categories
4. Delete all the categories

Expected Result:

Deleted categories should not reappear

Actual Result:

Deleted categories reappear

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

2024-11-22_00-46-04.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861090857183886137
• Upwork Job ID: 1861090857183886137
• Last Price Increase: 2024-12-02
• Automatic offers:
• ZhenjaHorbach | Contributor | 105437121

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @justinpersaud (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861090857183886137

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[justinpersaud]

Just leaving a note here that I'm going to be OOO starting tomorrow until Dec 9th. If anything requires engineering before then and I'm not around, feel free to reassign.

[melvin-bot]

@justinpersaud, @sakluger, @Pujan92 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

@Pujan92 any ideas on this one?

[zirgulis]

Hi, I'm Povilas from Callstack and I would like to work on this issue.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[sakluger]

Thanks @zirgulis! I've assigned you to the issue. Please let us know once you have a proposal for how to fix the issue.

[zirgulis]

@sakluger it's very difficult to reproduce this bug reliably, it seems to happen randomly. I've managed to only reproduce this a couple of times, not sure what are the exact steps to reproduce this. It might take quite some time to fully understand what's going on here. I have noticed an error in the browser console coming from onyx that it's not able to set policyCategories_ will keep investigating this

[ZhenjaHorbach]

@zirgulis
Nice
Thanks !
Could you update your proposal please ?

[zirgulis]

@ZhenjaHorbach updated the proposal below:

Problem:

In the WorkspaceCategoriesPage users are experiencing visual glitches in the SelectionListWithModal component where:

• previously deleted items briefly reappear
• not deleted items are appearing slowly.

Root Cause:

The List component is slow to render and sometimes displays stale data when switching from optimistic to success onyx data.

Proposed Changes:

• Add a filter function to filter out the list items immediately after list items are marked as pendingAction: delete. Code line to be added
• When offline, do not filter out the list since we want to display them in the disabled state.

Tests:
There could be an automated test introduced to measure proper render times after the categories are deleted

What alternative solutions did you explore? (Optional)
The previously proposed solution was to increase the list render cycles but there were some concerns regarding the performance regression.

[ZhenjaHorbach]

@zirgulis
Thanks for update !
This proposal makes sense to me !

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[zirgulis]

@ZhenjaHorbach @mountiny PR open: #54613

[ZhenjaHorbach]

@zirgulis
I think we need to wait for @blimpich decision 😅

Updates: but never mind
I'll do a review in a few hours following this thread !

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Filter deleted workspace categories #54613

If no regressions arise, payment will be issued on 2025-01-13. 🎊

For reference, here are some details about the assignees on this issue:

• @zirgulis does not require payment (Contractor)
• @ZhenjaHorbach requires payment automatic offer (Contributor)

[melvin-bot]

@ZhenjaHorbach @sakluger @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sakluger]

Hey @ZhenjaHorbach - could you please complete the BZ checklist before the payment due date on Jan 13? Thanks!

[ZhenjaHorbach]

Hey @ZhenjaHorbach - could you please complete the BZ checklist before the payment due date on Jan 13? Thanks!

Yes
Of course !
I will do it before January 13th

[ZhenjaHorbach]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

I don't think it's anyone's mistake
Since this screen has been around for a long time and is related to performance

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

• Create many categories in workspace categories page (at least 30)

Test:

1. Open workspace categories page
2. Remove most of the categories
3. Verify that removed categories are instantly removed from the list
4. Verify that the remaining categories appear immediately in the list

Do we agree 👍 or 👎

[sakluger]

Summarizing payment on this issue:

Contributor: @zirgulis - no payment required
Contributor+: @ZhenjaHorbach $250, paid via Upwork