[HOLD for payment 2024-12-19] [$125] Web - RHP - Going back closes the RHP Instead of navigating to the confirm page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.68-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #51630
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in with new Gmail account
3. Open a DM
4. Press + and choose Pay option
5. Enter any amount in USD and go Next
6. Press Pay with Expensify. A validate page will show
7. (web/desktop) Refresh
8. Go back

Expected Result:

Going back should navigate us to the confirm page.

Actual Result:

Going back closes the RHP

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679178_1732806280071.bandicam_2024-11-28_17-51-50-902.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864112749864088782
• Upwork Job ID: 1864112749864088782
• Last Price Increase: 2024-12-04
• Automatic offers:
• DylanDylann | Reviewer | 105193680
• FitseTLT | Contributor | 105193682

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-11-28 15:59:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - RHP - Going back closes the RHP Instead of navigating to the confirm page

What is the root cause of that problem?

We are navigating back without the backTo

App/src/pages/settings/Wallet/VerifyAccountPage.tsx

Line 53 in 64eaf2f

Navigation.goBack();

App/src/pages/settings/Wallet/VerifyAccountPage.tsx

Line 81 in 64eaf2f

onBackButtonPress={() => Navigation.goBack()}

App/src/pages/settings/Wallet/VerifyAccountPage.tsx

Line 67 in 64eaf2f

Navigation.goBack();

What changes do you think we should make in order to solve the problem?

We need to pass the backTo to the goBack

        Navigation.goBack(route.params.backTo);

What alternative solutions did you explore? (Optional)

But if we want to navigate to the backTo only on BackButtonPressed here

App/src/components/ValidateCodeActionModal/index.tsx

Line 73 in 64eaf2f

onBackButtonPress={hide}

and not onClose and onModalHide we can create a separate onBackPressed prop for ValidateCodeActionModal and pass the goBack with backTo passed as a callback and call it from only onBackButtonPress so that the onClose and onModalHide will call the normal backTo or dismissModal

App/src/components/ValidateCodeActionModal/index.tsx

Lines 57 to 59 in 64eaf2f

	isVisible={isVisible}
	onClose={hide}
	onModalHide={onModalHide ?? hide}

[melvin-bot]

@twisterdotcom Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864112749864088782

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[melvin-bot]

Upwork job price has been updated to $125

[DylanDylann]

@FitseTLT's proposal looks good to me

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Yep that looks good to me!

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Web - RHP - Going back closes the RHP Instead of navigating to the confirm page #53629

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @FitseTLT requires payment automatic offer (Contributor)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]