[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Search - Read message shown in bold in search router result

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.66-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

Prerequisite - User A send a message to user B
Steps

1. {User B} Navigate to https://staging.new.expensify.com/

2. {User B} Notice a new message is bold in LHN and Search router

3. {User B} Navigate to the message so that the message can be read

4. {User B} Notice LHN is not bold any more

5. {User B} Navigate to Search router

Expected Result:

As the Message is already read the Search router result should not be bold

Actual Result:

Read message shown in bold in search router result

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6679478_1732825516673.bandicam_2024-11-28_23-10-01-442.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[aldo-expensify]

Besides the chat name (participant name) being bolded, the last message is missing:

and instead we show the email.

This has very likely the same root cause as #53291

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[aldo-expensify]

I think #53293 (comment) fixes this

[aldo-expensify]

Made the PR ready for review: #53293

[mountiny]

@aldo-expensify this is apparently still not fixed based on qa testing here #53293 (comment)

[aldo-expensify]

@aldo-expensify this is apparently still not fixed based on qa testing here #53293 (comment)

😢 , will try to reproduce

Update:

Reproduced in staging again:

[aldo-expensify]

btw, I'm still trying to fix my dev env because Auth started crashing.... I reproduced in staging, but I haven't been able to work with my vm yet :(

[aldo-expensify]

hmm, I think this is fixed in main, but not in staging. Staging ended up in a not so great state when we CP'd #53293 because we are missing the changes from #53056:

I'm not sure about what to do here... we could also CP: #53056, but I'm not so sure.. it is a big refactor PR, or is that fine? @mountiny do you have some thoughts about this? 😬 🙇

[aldo-expensify]

Maybe we can ignore this and deploy #53056 normally on its time since the bold/no bod doesn't sound like a big issue to me

[mountiny]

@aldo-expensify Yes I think we can treat this as non-blocker, its minor issue and we can let the refactor go through normal process to catch any regressions on that. Thanks for digging 🙌

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.68-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix chat view in search router #53293

If no regressions arise, payment will be issued on 2024-12-07. 🎊

[melvin-bot]

@aldo-expensify @kadiealexander @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.69-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix chat view in search router #53293

If no regressions arise, payment will be issued on 2024-12-09. 🎊

[melvin-bot]

@aldo-expensify @kadiealexander @aldo-expensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[kadiealexander]

No payment due.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.