[HOLD for payment 2025-01-07] Expense - Receipt placeholder is blank without receipt icon when expense is deleted offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to chat.
3. Submit an expense.
4. Go offline.
5. Go to transaction thread.
6. Click on the report header > Delete expense.
7. Delete the expense.

Expected Result:

The receipt placeholder in the expense preview will show the receipt icon when the expense is deleted offline.

Actual Result:

The receipt placeholder in the expense preview is blank without receipt icon when the expense is deleted offline.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6683851_1733283433010.20241204_113335.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Different behavior in Prod

Screen.Recording.2024-12-04.at.11.17.07.AM.mov

[shubham1206agra]

Offending PR #52848

[brunovjk]

Do you have any idea what might be causing this bug @gijoe0295? I'll look into it in a moment. Thanks

[gijoe0295]

Checking

[youssef-lr]

any update @gijoe0295?

[gijoe0295]

@brunovjk I found the root cause but want to confirm the expected behavior before implementing the PR.

What do we want to show in receipt placeholder when the expense is deleted offline? Both in report preview & in expense preview.

1. Empty receipt placeholder:

2. Nothing (current production behavior):

cc @Expensify/design

[brunovjk]

I believe the first option, but @youssef-lr can you confirm it please? Thanks

[gijoe0295]

If we go with (1) then we should consider the case where there are more than 1 expense in the report and delete 1 of those offline, which would be shown in the report preview thumbnails? Hide the deleted ones or show empty placeholder for them (the deleted)?

I myself suggest (2). Because:

• When we delete an expense WITH receipt, we also do not show anything in receipt thumbnail (option 2)
• we clear the whole transaction data so it could be quite complicated if follow (1).

[youssef-lr]

I like option 2 as well.

[brunovjk]

Thank you @youssef-lr. Do you have everything you need to raise the PR @gijoe0295? Thank you :D

[melvin-bot]

@youssef-lr, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[gijoe0295]

Just need to test carefully. Will be ready tomorrow.

[bfitzexpensify]

Great, thank you @gijoe0295

[brunovjk]

Any updates on the PR @gijoe0295? Thanks

[gijoe0295]

@brunovjk Here is the PR #54051.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: blank receipt holder when delete expense offline #54051

If no regressions arise, payment will be issued on 2025-01-07. 🎊

[melvin-bot]

@youssef-lr @bfitzexpensify @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[brunovjk]

I believe we can go with the original issue. I created the regression test already considering the issue scenario here.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[bfitzexpensify]

Cool, closing this