Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-19] HybridApp iOS: Fix version mismatch for Notification Service Extension #53569

Closed
1 of 8 tasks
arosiclair opened this issue Dec 4, 2024 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@arosiclair
Copy link
Contributor

arosiclair commented Dec 4, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.70.9
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: N/A
Expensify/Expensify Issue URL: N/A
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C03V9A4TB/p1733271524517199?thread_ts=1733262728.540769&cid=C03V9A4TB

Action Performed:

Deploy new version of HybridApp

Expected Result:

No warnings from Apple about version mismatches in our bundle

Actual Result:

Google Chrome 2024-12-03 at 17 17 59

Workaround:

None

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @sakluger
@arosiclair arosiclair added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 4, 2024
@arosiclair arosiclair self-assigned this Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@arosiclair arosiclair added the Internal Requires API changes or must be handled by Expensify staff label Dec 4, 2024
@arosiclair
Copy link
Contributor Author

arosiclair commented Dec 4, 2024

@AndrewGable
Copy link
Contributor

Thank you!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 4, 2024
@arosiclair
Copy link
Contributor Author

Alright I prepped all of the changes in these PRs:

I think we have to merge them at the same time. You mind reviewing @AndrewGable?

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 12, 2024
@melvin-bot melvin-bot bot changed the title HybridApp iOS: Fix version mismatch for Notification Service Extension [HOLD for payment 2024-12-19] HybridApp iOS: Fix version mismatch for Notification Service Extension Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-19. 🎊

Copy link

melvin-bot bot commented Dec 12, 2024

@arosiclair @sakluger @arosiclair The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@arosiclair
Copy link
Contributor Author

This was just an issue with the deploy which should be fixed now. Closing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants