[HOLD for payment 2024-12-19] [$250] iOS - Search query is cut off at the bottom for certain letters

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.71-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53317
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Open hybrid app
2. Navigate to search
3. Tap on the search icon at the top right corner
4. Type lower case g multiple of times
5. Hit enter

Expected Result:

The letters does not get cut off at the bottom

Actual Result:

The lower case letter g and other letters like lower case p get cut off at the bottom

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

• Reproduced on iPhone 11 and iPhone 13 models.

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021864712686512100060
• Upwork Job ID: 1864712686512100060
• Last Price Increase: 2024-12-05
• Automatic offers:
• suneox | Reviewer | 105260216
• abzokhattab | Contributor | 105260217

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search query is cut off at the bottom for certain letters

What is the root cause of that problem?

in the SearchTypeMenuNarrow component, the container height is set to componentSizeNormal however the text height is set to large

App/src/pages/Search/SearchTypeMenuNarrow.tsx

Lines 181 to 200 in be17e04

	<Animated.View style={[styles.tabSelectorButton, styles.tabBackground(hovered, true, theme.border), styles.w100, StyleUtils.getHeight(variables.componentSizeNormal)]}>
	<View style={[styles.flexRow, styles.gap2, styles.alignItemsCenter, titleViewStyles]}>
	<Icon
	src={menuIcon}
	fill={theme.icon}
	small
	/>
	<Text
	numberOfLines={1}
	style={[styles.textStrong, styles.flexShrink1, styles.label]}
	>
	{menuTitle}
	</Text>
	<Icon
	src={Expensicons.DownArrow}
	fill={theme.icon}
	small
	/>
	</View>
	</Animated.View>

App/src/styles/index.ts

Lines 379 to 382 in 2403fcd

	label: {
	fontSize: variables.fontSizeLabel,
	lineHeight: variables.lineHeightLarge,
	},

What changes do you think we should make in order to solve the problem?

• we should either change the view height to be large and match the text height
• or change the text height to normal

                                style={[styles.textStrong, styles.flexShrink1, styles.textLineHeightNormal, styles.fontSizeLabel]}

Result

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[isabelastisser]

I think hybrid issues need to be internal.

[abzokhattab]

should it be external? i see its happening on ios standalone as well not only the hybrid.

for reference here is a similar issue #49890

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021864712686512100060

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[suneox]

@abzokhattab proposal LGTM. This solution can resolve this issue while still addressing issue #49890

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

Yep that works as root cause; in terms of the actual solution I think it probably makes sense to change the view height and keep the text size as is (of the two proposed options)? cc @Expensify/design

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[shawnborton]

Nice, the line height solution seems super straight forward.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixing search query line height #53837

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Reviewer)
• @abzokhattab requires payment automatic offer (Contributor)

[melvin-bot]

@suneox @isabelastisser @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[suneox]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/50075/files#r1885756110

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

N/A: Due to it isn't an impactful bug