Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$250] Fix onboarding modal in macOS Chrome/Safari #53724

Open
carlosmiceli opened this issue Dec 6, 2024 · 10 comments
Open

[$250] Fix onboarding modal in macOS Chrome/Safari #53724

carlosmiceli opened this issue Dec 6, 2024 · 10 comments
Assignees
@carlosmiceli @slafortune @hungvu193 @Shahidullah-Muffakir
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor

Comments

@carlosmiceli
Copy link
Contributor

carlosmiceli commented Dec 6, 2024 •
edited
Loading

The onboarding modal seems to have issues being displayed in macOS in Chrome and Safari (conversation, GH comment). Seems like there is an issue with screen size and/or refresh. Please fix it and ensure it's always displayed in all possible platforms. We found this while working on this issue: #53326

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021865160679237341916
  • Upwork Job ID: 1865160679237341916
  • Last Price Increase: 2024-12-06
Issue OwnerCurrent Issue Owner: @hungvu193
@carlosmiceli carlosmiceli added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 6, 2024
@carlosmiceli carlosmiceli self-assigned this Dec 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2024

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@carlosmiceli carlosmiceli added the External Added to denote the issue can be worked on by a contributor label Dec 6, 2024
@melvin-bot melvin-bot bot changed the title Fix onboarding modal in macOS Chrome/Safari [$250] Fix onboarding modal in macOS Chrome/Safari Dec 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021865160679237341916

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 6, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@carlosmiceli carlosmiceli mentioned this issue Dec 6, 2024
Open
@Shahidullah-Muffakir
Copy link
Contributor

Coming from #53326 (comment). I’ll work on this, thanks!

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 7, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 7, 2024

📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@Shahidullah-Muffakir
Copy link
Contributor

@carlosmiceli as per #53284 (comment) and after testing with same steps, the onboarding modal works as expected in staging when signing up through staging.expensify.com, after redirecting to staging.new.expensify.com the onboarding flow modal appears as expected. However, the issue persists in prod.
Considering this, should we wait for the next production deploy to see if the issue resolves? Thank you.

@carlosmiceli
Copy link
Contributor Author

should we wait for the next production deploy to see if the issue resolves?

Yes, that sounds like a good idea.

@melvin-bot melvin-bot bot added the Overdue label Dec 9, 2024
@carlosmiceli
Copy link
Contributor Author

Not overdue.

@carlosmiceli carlosmiceli added Daily KSv2 and removed Daily KSv2 labels Dec 9, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 9, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 13, 2024

@carlosmiceli, @slafortune, @hungvu193, @Shahidullah-Muffakir Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Dec 13, 2024
@carlosmiceli
Copy link
Contributor Author

Still discussing details in the PR.

@carlosmiceli carlosmiceli added Weekly KSv2 and removed Daily KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2024
@carlosmiceli carlosmiceli removed the Weekly KSv2 label Dec 13, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosmiceli carlosmiceli

@slafortune slafortune

@hungvu193 hungvu193

@Shahidullah-Muffakir Shahidullah-Muffakir

Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@carlosmiceli @slafortune @hungvu193 @Shahidullah-Muffakir