Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Implement animation to the switch expandable sections #53759

Open
mountiny opened this issue Dec 9, 2024 · 21 comments
Open

[$250] Implement animation to the switch expandable sections #53759

mountiny opened this issue Dec 9, 2024 · 21 comments
Assignees
Labels
Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Dec 9, 2024

This is a request from @dubielzyk-expensify to add animation to the expanding section in Workflows (and other similar places in the app) where after toggling the switch, we open the section like this https://github.com/user-attachments/assets/43e48c18-6b18-4ec6-bc7f-3238f125d616

cc @sumo-slonik @blazejkustra would like to implement this - can you please comment

@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021866452926963427651
  • Upwork Job ID: 1866452926963427651
  • Last Price Increase: 2024-12-10
Issue OwnerCurrent Issue Owner: @sumo-slonik
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. Design labels Dec 9, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Dec 9, 2024

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@dubielzyk-expensify
Copy link
Contributor

@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?

Let's start with an ease-out and see how that feels. Excited about this :)

@sumo-slonik
Copy link
Contributor

Hi, I am very eager to get started on this :)
I have an idea how to do it using reanimated and I'm already on it

@shubham1206agra
Copy link
Contributor

Assign me here for review please.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Dec 10, 2024
@melvin-bot melvin-bot bot changed the title Implement animation to the switch expandable sections [$250] Implement animation to the switch expandable sections Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021866452926963427651

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 10, 2024
@mountiny
Copy link
Contributor Author

I think we can just use the autoassigner, its a new task and no rush

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 10, 2024
@sumo-slonik
Copy link
Contributor

Is already working, I am checking where in other places of the application could be used such acordition element with switch

Screen.Recording.2024-12-10.at.16.37.49.mov
Screen.Recording.2024-12-10.at.16.39.02.mov

@mountiny
Copy link
Contributor Author

@sumo-slonik we also use it in accounting settings

@mountiny
Copy link
Contributor Author

you have to connected to QBO for example

@sumo-slonik
Copy link
Contributor

It is already working everywhere the last place with a problem is the accounting tab, there I have a problem when importing because the component changes before the widget collapses and this causes the illusion of not smooth animation, I have to change the logic of state management in this place, but we are getting closer :D

Screen.Recording.2024-12-11.at.14.55.27.mov

@sumo-slonik
Copy link
Contributor

while working on animations in imoprt I found such a bug on main branch, I wanted to fix it within this task but it is more work than what is related to animations so I think it deserves a separate issiue:

bug1.mp4

@sumo-slonik
Copy link
Contributor

All switch animations completed:

Screen.Recording.2024-12-12.at.14.41.27.mov

@sumo-slonik
Copy link
Contributor

@mountiny What do we want to do about this bug?
#53759 (comment)

@mountiny
Copy link
Contributor Author

@sumo-slonik I dont think we ahve to worry about this, its a replay effect issue no need to spend time on it

@mountiny
Copy link
Contributor Author

@dubielzyk-expensify how does the animation look to you?

@sumo-slonik
Copy link
Contributor

Also draft PR already has recordings from all platforms:
#53938

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 16, 2024
@sumo-slonik
Copy link
Contributor

PR is ready:
#53938

@blazejkustra
Copy link
Contributor

@thesahindia I think you can have a look at the code and start reviewing 😄 Let us know if you have any questions

@stephanieelliott
Copy link
Contributor

PR is still under review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

7 participants