-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] Implement animation to the switch expandable sections #53759
Comments
Current assignee @dubielzyk-expensify is eligible for the Design assigner, not assigning anyone new. |
Triggered auto assignment to @stephanieelliott ( |
Let's start with an |
Hi, I am very eager to get started on this :) |
Assign me here for review please. |
Job added to Upwork: https://www.upwork.com/jobs/~021866452926963427651 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia ( |
I think we can just use the autoassigner, its a new task and no rush |
Is already working, I am checking where in other places of the application could be used such acordition element with switch Screen.Recording.2024-12-10.at.16.37.49.movScreen.Recording.2024-12-10.at.16.39.02.mov |
@sumo-slonik we also use it in accounting settings |
you have to connected to QBO for example |
It is already working everywhere the last place with a problem is the accounting tab, there I have a problem when importing because the component changes before the widget collapses and this causes the illusion of not smooth animation, I have to change the logic of state management in this place, but we are getting closer :D Screen.Recording.2024-12-11.at.14.55.27.mov |
while working on animations in imoprt I found such a bug on main branch, I wanted to fix it within this task but it is more work than what is related to animations so I think it deserves a separate issiue: bug1.mp4 |
All switch animations completed: Screen.Recording.2024-12-12.at.14.41.27.mov |
@mountiny What do we want to do about this bug? |
@sumo-slonik I dont think we ahve to worry about this, its a replay effect issue no need to spend time on it |
@dubielzyk-expensify how does the animation look to you? |
Also draft PR already has recordings from all platforms: |
PR is ready: |
@thesahindia I think you can have a look at the code and start reviewing 😄 Let us know if you have any questions |
PR is still under review! |
This is a request from @dubielzyk-expensify to add animation to the expanding section in Workflows (and other similar places in the app) where after toggling the switch, we open the section like this https://github.com/user-attachments/assets/43e48c18-6b18-4ec6-bc7f-3238f125d616
cc @sumo-slonik @blazejkustra would like to implement this - can you please comment
@dubielzyk-expensify do you have some specifics about the easing/ animation at this moment?
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @sumo-slonikThe text was updated successfully, but these errors were encountered: