[HOLD for payment 2024-12-19] [HOLD for payment 2024-12-17] iOS - Expense - App returns to transaction thread when trying to replace receipt, then freezes

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch ND or hybrid app.
2. Go to workspace chat.
3. Submit an expense with receipt.
4. Go to transaction thread.
5. Tap on the receipt.
6. Tap 3-dot menu > Replace.

Expected Result:

Replace receipt page will open.

Actual Result:

App returns to transaction thread, then app freezes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6689959_1733833378116.ScreenRecording_12-10-2024_20-20-10_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[youssef-lr]

Can reproduce, pretty bad regression. Checking the deploy checklist for an offending PR.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App returns to transaction thread, then app freezes.

What is the root cause of that problem?

It comes from #53108. On IOS, we call onModalClose with a delay then we navigate to the scan page first then we call dismissModal here. That cause we go back to the TransactionReceiptPage and now the modal is hidden which is the freeze.

App/src/components/AttachmentModal.tsx

Line 388 in c8e8517

attachmentModalHandler.handleModalClose(onModalClose);

App/src/libs/AttachmentModalHandler/index.ios.ts

Lines 11 to 15 in c8e8517

	InteractionManager.runAfterInteractions(() => {
	onCloseCallback?.();
	});
	},
	};

What changes do you think we should make in order to solve the problem?

We should only call onModalClose with a delay when it's not receipt attachment

if (!isEmptyObject(report) && !isReceiptAttachment) {
     attachmentModalHandler.handleModalClose(onModalClose); 
} else {
    onModalClose();
}

App/src/components/AttachmentModal.tsx

Line 388 in c8e8517

attachmentModalHandler.handleModalClose(onModalClose);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[huult]

@Beamanator Can we add InteractionManager.runAfterInteractions for each onClose event instead of using it within AttachmentModal?

[Beamanator]

Mmmmm i mean yeah if that would be cleaner, that would work well! But using it within AttachmentModal like suggested above might make it so we don't have to remember to wrap onClose outside of AttachmentModal in the future, right?

[huult]

@Beamanator Yes, you are correct

[luacmartins]

Confirmed this is fixed in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add shouldCallDirectly for closeModal logic #53873

If no regressions arise, payment will be issued on 2024-12-17. 🎊

[melvin-bot]

@youssef-lr @zanyrenney @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Add shouldCallDirectly for closeModal logic #53873

If no regressions arise, payment will be issued on 2024-12-19. 🎊

[melvin-bot]

@youssef-lr @zanyrenney @youssef-lr The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]