[CRITICAL] Confirm if migration members will see onboarding modal when they shouldn't

[jamesdeanexpensify]

Background

Slack convo

There have been numerous instances of Expensify members who already belong to a workspace being taken through the onboarding modal and creating additional, erroneous workspaces. We should not be showing the onboarding modal to those members at all, and we're concerned this may turn into an even bigger issue once migration begins.

Examples

• [email protected] (clip) - looking in Supportal, they're already a member of a group Control workspace, so they shouldn't be shown the onboarding modal - but they're taken through the onboarding modal and end up creating a new workspace erroneously
• [email protected] (clip) - looking in Supportal, they're already a member of a group Control workspace (they also experience a bug where they get stuck in an infinite onboarding modal loop, but that's been logged separately here)
• [email protected] (clip) - ignore the looping onboarding modal, that bug has already been logged. But this member already belongs to a group Control workspace so they shouldn't be taken through the onboarding modal.

Potential solution

If someone is already a workspace member and does not have the introSelected NVP, then we should not show the onboarding modal.

cc @danielrvidal @francoisl @deetergp @puneetlath @flaviadefaria

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jamesdeanexpensify]

@slafortune I'm going to grab an internal engineer for this one so I'll remove you!

[melvin-bot]

@deetergp Whoops! This issue is 2 days overdue. Let's get this updated quick!