Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-20] [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes #53992

Closed
2 of 8 tasks
IuliiaHerets opened this issue Dec 12, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: V9. 0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap fab - create expense
  3. Enter big number 8 digits
  4. Select a different currency
  5. Note the next button alignment

Expected Result:

After selecting different currency, for big number next button alignment must not change.

Actual Result:

After selecting different currency, for big number next button alignment changes from middle to left.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6691834_1733985592663.Screenrecorder-2024-12-12-12-06-14-59.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021867194147621109596
  • Upwork Job ID: 1867194147621109596
  • Last Price Increase: 2024-12-12
Issue OwnerCurrent Issue Owner: @rojiphil
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 12, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Production behavior

Screenrecorder-2024-12-12-08-58-19-93.mp4

@NikkiWines
Copy link
Contributor

I'm unable to reproduce this on staging or production - demoting this from a blocker and the needs repro label.

ScreenRecording_12-12-2024.13-40-12_1.MP4
ScreenRecording_12-12-2024.13-42-22_1.mov

@NikkiWines NikkiWines added Needs Reproduction Reproducible steps needed Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 12, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@allgandalf

This comment was marked as outdated.

@allroundexperts
Copy link
Contributor

@allgandalf I already posted on Slack 😄

@allroundexperts
Copy link
Contributor

This is easily reproducible. Here are the steps:

  1. In android chrome, open https://staging.new.expensify.com
  2. Click on the Fab, then click on Create Expense
  3. Enter an amount like 22222222
  4. Click next, and enter a recipient email like: [email protected]
  5. Click next, and on the review screen, click on the amount again.

It can be easily seen that the Next button is misaligned.

Screen.Recording.2024-12-12.at.5.47.42.PM.mov

@NikkiWines
Copy link
Contributor

Cool 👍 Re-applying appropriate labels then - not sure why I don't see the UI issue (even following those updated steps, thanks @allroundexperts) but happy to have this one investigated.

@NikkiWines NikkiWines added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 and removed Weekly KSv2 Needs Reproduction Reproducible steps needed labels Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021867194147621109596

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
Copy link

melvin-bot bot commented Dec 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

@rojiphil
Copy link
Contributor

Unassigning myself as @allroundexperts is taking this over

@rojiphil rojiphil removed their assignment Dec 12, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
@NikkiWines NikkiWines added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 12, 2024
@Unique-Programmer
Copy link

Hi, could you please help me, should I post what I think is the correct solution here in the comments?

Copy link

melvin-bot bot commented Dec 12, 2024

📣 @Unique-Programmer! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Unique-Programmer
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01588b7de4d2e62c93

Copy link

melvin-bot bot commented Dec 12, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@luacmartins
Copy link
Contributor

Caused by #53740

@luacmartins
Copy link
Contributor

Revert merged and being Cped

@luacmartins
Copy link
Contributor

Fixed in staging

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Dec 12, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Dec 13, 2024
@melvin-bot melvin-bot bot changed the title [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes [HOLD for payment 2024-12-20] [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-20. 🎊

Copy link

melvin-bot bot commented Dec 13, 2024

@NikkiWines / @luacmartins @NikkiWines / @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

10 participants