-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-20] [$250] mWeb - BNP - After selecting different currency, for big number next button alignment changes #53992
Comments
Triggered auto assignment to @NikkiWines ( |
Triggered auto assignment to @abekkala ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Production behavior Screenrecorder-2024-12-12-08-58-19-93.mp4 |
I'm unable to reproduce this on staging or production - demoting this from a blocker and the needs repro label. ScreenRecording_12-12-2024.13-40-12_1.MP4ScreenRecording_12-12-2024.13-42-22_1.mov |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
This comment was marked as outdated.
This comment was marked as outdated.
@allgandalf I already posted on Slack 😄 |
This is easily reproducible. Here are the steps:
It can be easily seen that the Screen.Recording.2024-12-12.at.5.47.42.PM.mov |
Cool 👍 Re-applying appropriate labels then - not sure why I don't see the UI issue (even following those updated steps, thanks @allroundexperts) but happy to have this one investigated. |
Triggered auto assignment to @cristipaval ( |
Job added to Upwork: https://www.upwork.com/jobs/~021867194147621109596 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil ( |
Unassigning myself as @allroundexperts is taking this over |
Hi, could you please help me, should I post what I think is the correct solution here in the comments? |
📣 @Unique-Programmer! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Caused by #53740 |
Revert merged and being Cped |
Fixed in staging |
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-20. 🎊 |
@NikkiWines / @luacmartins @NikkiWines / @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: V9. 0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Redmi note 10s android 13
App Component: Money Requests
Action Performed:
Expected Result:
After selecting different currency, for big number next button alignment must not change.
Actual Result:
After selecting different currency, for big number next button alignment changes from middle to left.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6691834_1733985592663.Screenrecorder-2024-12-12-12-06-14-59.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @rojiphilThe text was updated successfully, but these errors were encountered: