Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An 'Unexpected Error' occurs when approving C+ reports, but the reports are successfully approved. #54092

Closed
1 of 8 tasks
m-natarajan opened this issue Dec 13, 2024 · 26 comments
Closed
1 of 8 tasks
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @garrettmknight
Slack conversation (hyperlinked to channel name): quality

Action Performed:

  1. Approve a bunch of submitted C+ report

Expected Result:

All the reports got approved

Actual Result:

Unexpected Error’ message displayed for two reports
“Error processing command ‘Get’ (407 Missing authToken), ignoring.”

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screenshot 2024-12-12 at 11 32 07 AM

Logs

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @techievivek
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Dec 13, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @techievivek (AutoAssignerNewDotQuality)

Copy link

melvin-bot bot commented Dec 16, 2024

@stephanieelliott, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Dec 17, 2024
@stephanieelliott
Copy link
Contributor

Hey @techievivek can you take a look at this?

@melvin-bot melvin-bot bot removed the Overdue label Dec 18, 2024
@techievivek
Copy link
Contributor

Sorry, I forgot to post the updates here. I posted a comment in the linked slack thread, this seems to be an issue with authToken expiring when we are fetching the onyx updates for the user. I will bring a discussion in the #eng-chat channel to discuss this further.

@techievivek techievivek removed the Weekly KSv2 label Dec 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 20, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

@stephanieelliott, @techievivek Eep! 4 days overdue now. Issues have feelings too...

@techievivek
Copy link
Contributor

Not overdue, will investigate this again today.

@melvin-bot melvin-bot bot removed the Overdue label Dec 25, 2024
Copy link

melvin-bot bot commented Dec 27, 2024

@stephanieelliott @techievivek this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

@stephanieelliott, @techievivek Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Jan 1, 2025

@stephanieelliott, @techievivek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@techievivek
Copy link
Contributor

Looking into it now.

@melvin-bot melvin-bot bot removed the Overdue label Jan 1, 2025
@techievivek
Copy link
Contributor

Pushed a PR for adding some logs here https://github.com/Expensify/Web-Expensify/pull/44945, it is a widespread issue when we try to send push notification for IOU action.

@techievivek
Copy link
Contributor

@garrettmknight garrettmknight removed the Needs Reproduction Reproducible steps needed label Jan 2, 2025
@techievivek
Copy link
Contributor

techievivek commented Jan 6, 2025

We have a clear understanding of the issue now, I am discussing the solution with the team here https://expensify.slack.com/archives/C03TQ48KC/p1736145923335859?thread_ts=1735746048.891849&cid=C03TQ48KC

@melvin-bot melvin-bot bot added the Overdue label Jan 8, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

@stephanieelliott, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

@stephanieelliott
Copy link
Contributor

Hey @techievivek have we come up with a solution for this one?

@techievivek
Copy link
Contributor

Will provide an update today.

@melvin-bot melvin-bot bot removed the Overdue label Jan 13, 2025
Copy link

melvin-bot bot commented Jan 13, 2025

@stephanieelliott, @techievivek Still overdue 6 days?! Let's take care of this!

@melvin-bot melvin-bot bot added the Overdue label Jan 15, 2025
@techievivek
Copy link
Contributor

Pushed a PR for this.

@melvin-bot melvin-bot bot removed the Overdue label Jan 15, 2025
@techievivek techievivek added the Reviewing Has a PR in review label Jan 20, 2025
@stephanieelliott
Copy link
Contributor

PR is being actively reviewed

Copy link

melvin-bot bot commented Jan 27, 2025

@stephanieelliott, @techievivek Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 29, 2025

@stephanieelliott, @techievivek Huh... This is 4 days overdue. Who can take care of this?

@stephanieelliott
Copy link
Contributor

PR is on staging

@techievivek
Copy link
Contributor

The PR is now live on PROD, and I have confirmed that the Error processing command 'Get' (407 Missing authToken) error log no longer appears in the push notification flow for IOUs or any other actions requiring an authToken. I will go ahead and close this.

@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

5 participants