Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-30] [$250] NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. #54142

Closed
1 of 8 tasks
m-natarajan opened this issue Dec 13, 2024 · 19 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation (hyperlinked to channel name): quality

Action Performed:

  1. Open NewDot on the staging environment.
  2. Navigate to any chat.
  3. Allow the application to refresh automatically or perform a manual refresh.

Expected Result:

The application should load the content normally without errors after a refresh.

Actual Result:

The error message "Uh-oh, something went wrong!" is displayed regardless of the chat being viewed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
4.New.Expensify.-.13.December.2024.mp4

onyx-state (3).txt

image (5)

image (6)

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Dec 13, 2024
Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Dec 13, 2024

Triggered auto assignment to @aldo-expensify (AutoAssignerNewDotQuality)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 13, 2024
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@s77rt
Copy link
Contributor

s77rt commented Dec 14, 2024

Not able to reproduce yet but this is very likely a regression from #53751

@s77rt
Copy link
Contributor

s77rt commented Dec 14, 2024

Okay I'm able to reproduce.

Reproduction steps:

  1. Onyx.merge('user', {isGuide: true});
  2. Refresh
Screen.Recording.2024-12-14.at.1.09.59.AM.mov

@s77rt
Copy link
Contributor

s77rt commented Dec 14, 2024

Since this is probably a regression and it's still within the regression period, the author should fix it. cc @jnowakow @allroundexperts @mountiny

@jnowakow
Copy link
Contributor

Hello, I think I have fix for this one

@twisterdotcom
Copy link
Contributor

Assigned you @jnowakow

@twisterdotcom twisterdotcom removed the Needs Reproduction Reproducible steps needed label Dec 16, 2024
@twisterdotcom
Copy link
Contributor

Assigned you for the review @s77rt as you reproduced it, but if you think @allroundexperts should take it, LMK.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 16, 2024
@muttmuure muttmuure moved this to CRITICAL in [#whatsnext] #quality Dec 23, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Dec 23, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Dec 23, 2024
@melvin-bot melvin-bot bot changed the title NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. [HOLD for payment 2024-12-30] NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. Dec 23, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 23, 2024
Copy link

melvin-bot bot commented Dec 23, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 23, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment through NewDot Manual Requests
  • @jnowakow does not require payment (Contractor)

Copy link

melvin-bot bot commented Dec 23, 2024

@s77rt @twisterdotcom @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@s77rt
Copy link
Contributor

s77rt commented Dec 28, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: [HOLD for payment 2024-12-19] Fix the pusher instance not found crash #53752 (comment)

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: n/a

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Bug requires regression test: No. This bug can only be reproducible by guides and it's a crash where a test is not really needed

Regression Test Proposal Template
  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 30, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

Payment Summary

Upwork Job

  • Reviewer: @s77rt owed $250 via NewDot
  • Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Jan 1, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

@twisterdotcom, @s77rt, @jnowakow, @aldo-expensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 6, 2025

@twisterdotcom, @s77rt, @jnowakow, @aldo-expensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-12-30] NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. [HOLD for payment 2024-12-30] [$250] NewDot application on staging consistently shows the error message "Uh-oh, something went wrong!" whenever it refreshes, either automatically in the background or through a manual refresh. Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@twisterdotcom
Copy link
Contributor

Payment Summary:

  • @s77rt paid $250 via NewDot Manual Request
  • @jnowakow does not require payment (Contractor)

@melvin-bot melvin-bot bot removed the Overdue label Jan 6, 2025
@github-project-automation github-project-automation bot moved this from CRITICAL to Done in [#whatsnext] #quality Jan 6, 2025
@JmillsExpensify
Copy link

$250 approved for @s77rt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Status: Done
Development

No branches or pull requests

7 participants