Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - The top of the confirmation page header is not “Check your info.” #54749

Closed
4 of 8 tasks
IuliiaHerets opened this issue Jan 2, 2025 · 13 comments
Closed
4 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.0.80-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #52322
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: User Settings

Action Performed:

  1. Login to any account
  2. Go to Account settings > Wallet.
  3. Click Add bank account.
  4. Select any country other than US.
  5. Enter valid info and reach confirmation page.

Expected Result:

The top of the page has a header with “Check your info.”

Actual Result:

the top of the page header is Add Bank account

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6705006_1735810341982.Screen_Recording_2025-01-02_at_8.34.07_in_the_morning.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 2, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 2, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

This seems like a copy change not a bug

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

It looks like that copy for the bank account flow was added here #52054. I don't think this is a blocker, but we can confirm / update regression steps before we close this out

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

@pasyukevich @ishpaul777 could you confirm that we need to update the regression steps for this one?

Copy link

melvin-bot bot commented Jan 6, 2025

@mallenexpensify, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@pasyukevich
Copy link
Contributor

@grgia Could you clarify here what we need to update? Issue is not reproducible after the PR

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Jan 8, 2025

I'm confused, @madmax330 , 👀 plz since you seems to have worked on this (@ishpaul777 too if you know what's up).

  1. We want to confirm that the actual result "the top of the page header is Add Bank account" is expected
  2. If yes to 1, we want to know if any regression tests need to be updated so that QA doesn't report this as a bug again. Then we can close this.

(@grgia , comment if that's not what you're thinking too)

@melvin-bot melvin-bot bot removed the Overdue label Jan 8, 2025
@ishpaul777
Copy link
Contributor

sorry i dont have full context for the feature i have only worked on review for 1 PR few weeks ago, i see @shubham1206agra to be involved in PRs related to this feature he might have the required context

@shubham1206agra
Copy link
Contributor

I have already fixed this in 976956e. So nothing to be done here.

@grgia
Copy link
Contributor

grgia commented Jan 8, 2025

Cool, closing!

@grgia grgia closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

6 participants