-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$125] mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. #56747
Comments
Triggered auto assignment to @twisterdotcom ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Keyboard remains opened when opening the "Flag as offensive" page What is the root cause of that problem?We are not dismissing the keyboard before navigating to the flag as offensive page: App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx Lines 642 to 644 in 5ddef34
This causes the keyboard to remain open What changes do you think we should make in order to solve the problem?We need to dismiss the keyboard first before navigating like we did here: App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx Lines 265 to 268 in 5ddef34
if (closePopover) {
hideContextMenu(false, () => {
KeyboardUtils.dismiss().then(() => {
Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction?.reportActionID, activeRoute));
})
});
return;
} What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?N/A this is a simple bug of keyboard dismisal What alternative solutions did you explore? (Optional) |
Agree, weird. Going to make it $125 here though. |
Job added to Upwork: https://www.upwork.com/jobs/~021889826227174733114 |
Upwork job price has been updated to $125 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha ( |
can take care of internal review on this one when ready |
@twisterdotcom any specific reason to lower the bounty, I guess the standard $250 would be fine here :)) Similar issues had the same bounty:
So i guess $250 would be fine for this one too :)) |
I guess we don't really have a standardised approach here, but IMO this is a lower value thing for us to fix as it doesn't actually prevent the app from being used and it's not a common flow. Both of the above issues are far more common or important flows. |
@twilight2294's proposal looks good to me. I think i've seen this issue before on a different page, @twilight2294 do you think you can find similar issue on other pages & fix it here to possibly raise the bounty? what do you think @twisterdotcom? 🎀 👀 🎀 C+ Reviewed. |
Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
📣 @twilight2294 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
Yes works for me !!!, @twisterdotcom would it be okay to increase the bounty if we fix the issue on other pages? |
Yes, absolutely. I will add a $125 bonus on after. Please keep me honest on that @getusha and @twilight2294 as we get there though. |
@carlosmiceli, @dangrous, @twisterdotcom, @getusha, @twilight2294 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Thanks @twisterdotcom , raising the PR today |
@carlosmiceli, @dangrous, @twisterdotcom, @getusha, @twilight2294 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, @twilight2294 has a PR up. |
@twilight2294 Eep! 4 days overdue now. Issues have feelings too... |
@getusha @twilight2294 how are we looking on the PR? |
I only opened the PR for review 2 days back, sorry for the delay |
Cool, thank you! @getusha have you had a chance to review? |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.97-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View
Action Performed:
Expected Result:
Keyboard should not be opened again when user is navigated to "Flag as offensive" page.
Actual Result:
Keyboard remains opened when flagging a comment as offensive and landing on a new page.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6740316_1739343065567.Flg.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @twilight2294The text was updated successfully, but these errors were encountered: