Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$125] mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. #56747

Open
1 of 8 tasks
IuliiaHerets opened this issue Feb 12, 2025 · 23 comments
Open
1 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 12, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.97-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome
App Component: Chat Report View

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open any chat where messages from another user can be found.
  3. Open the keyboard if it´s not opened yet.
  4. Long tap on any message from another user and select "Flag as offensive"
  5. Check the keyboard behaviour when redirected to the "Flag as offensive" page.

Expected Result:

Keyboard should not be opened again when user is navigated to "Flag as offensive" page.

Actual Result:

Keyboard remains opened when flagging a comment as offensive and landing on a new page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6740316_1739343065567.Flg.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021889826227174733114
  • Upwork Job ID: 1889826227174733114
  • Last Price Increase: 2025-02-12
  • Automatic offers:
    • twilight2294 | Contributor | 106148397
Issue OwnerCurrent Issue Owner: @twilight2294
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@twilight2294
Copy link
Contributor

twilight2294 commented Feb 12, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Keyboard remains opened when opening the "Flag as offensive" page

What is the root cause of that problem?

We are not dismissing the keyboard before navigating to the flag as offensive page:

if (closePopover) {
hideContextMenu(false, () => Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction?.reportActionID, activeRoute)));
return;

This causes the keyboard to remain open

What changes do you think we should make in order to solve the problem?

We need to dismiss the keyboard first before navigating like we did here:

hideContextMenu(false, () => {
KeyboardUtils.dismiss().then(() => {
navigateToAndOpenChildReport(reportAction?.childReportID, reportAction, originalReportID);
});

            if (closePopover) {
                hideContextMenu(false, () => {
                    KeyboardUtils.dismiss().then(() => {
                        Navigation.navigate(ROUTES.FLAG_COMMENT.getRoute(reportID, reportAction?.reportActionID, activeRoute));
                    })
                });
                return;
            }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A this is a simple bug of keyboard dismisal

What alternative solutions did you explore? (Optional)

@twisterdotcom
Copy link
Contributor

Agree, weird. Going to make it $125 here though.

@twisterdotcom twisterdotcom added the External Added to denote the issue can be worked on by a contributor label Feb 12, 2025
@melvin-bot melvin-bot bot changed the title mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. [$250] mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021889826227174733114

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 12, 2025
@twisterdotcom twisterdotcom changed the title [$250] mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. [$125] mWeb - Chat - Keyboard remains opened when opening the "Flag as offensive" page. Feb 12, 2025
Copy link

melvin-bot bot commented Feb 12, 2025

Upwork job price has been updated to $125

Copy link

melvin-bot bot commented Feb 12, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

@dangrous dangrous self-assigned this Feb 13, 2025
@dangrous
Copy link
Contributor

can take care of internal review on this one when ready

@twilight2294
Copy link
Contributor

Agree, weird. Going to make it $125 here though.

@twisterdotcom any specific reason to lower the bounty, I guess the standard $250 would be fine here :))

Similar issues had the same bounty:

So i guess $250 would be fine for this one too :))

@twisterdotcom
Copy link
Contributor

I guess we don't really have a standardised approach here, but IMO this is a lower value thing for us to fix as it doesn't actually prevent the app from being used and it's not a common flow. Both of the above issues are far more common or important flows.

@getusha
Copy link
Contributor

getusha commented Feb 16, 2025

@twilight2294's proposal looks good to me. I think i've seen this issue before on a different page, @twilight2294 do you think you can find similar issue on other pages & fix it here to possibly raise the bounty? what do you think @twisterdotcom?

🎀 👀 🎀 C+ Reviewed.

Copy link

melvin-bot bot commented Feb 16, 2025

Triggered auto assignment to @carlosmiceli, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 16, 2025
Copy link

melvin-bot bot commented Feb 16, 2025

📣 @twilight2294 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@twilight2294
Copy link
Contributor

@twilight2294 do you think you can find similar issue on other pages & fix it here to possibly raise the bounty?

Yes works for me !!!, @twisterdotcom would it be okay to increase the bounty if we fix the issue on other pages?

@twisterdotcom
Copy link
Contributor

twisterdotcom commented Feb 17, 2025

Yes, absolutely. I will add a $125 bonus on after. Please keep me honest on that @getusha and @twilight2294 as we get there though.

Copy link

melvin-bot bot commented Feb 20, 2025

@carlosmiceli, @dangrous, @twisterdotcom, @getusha, @twilight2294 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 20, 2025
@twilight2294
Copy link
Contributor

Thanks @twisterdotcom , raising the PR today

@melvin-bot melvin-bot bot removed the Overdue label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

@carlosmiceli, @dangrous, @twisterdotcom, @getusha, @twilight2294 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Feb 24, 2025
@carlosmiceli
Copy link
Contributor

Not overdue, @twilight2294 has a PR up.

Copy link

melvin-bot bot commented Feb 26, 2025

@twilight2294 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Feb 26, 2025
@dangrous
Copy link
Contributor

@getusha @twilight2294 how are we looking on the PR?

@twilight2294
Copy link
Contributor

@twilight2294
Copy link
Contributor

I only opened the PR for review 2 days back, sorry for the delay

@dangrous
Copy link
Contributor

dangrous commented Mar 3, 2025

Cool, thank you! @getusha have you had a chance to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants