Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2021-10-15 #5879

Closed
OSBotify opened this issue Oct 15, 2021 · 21 comments
Closed

Deploy Checklist: New Expensify 2021-10-15 #5879

OSBotify opened this issue Oct 15, 2021 · 21 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 15, 2021 •
edited by roryabraham
Loading

Release Version: 1.1.8-9
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 15, 2021
@mvtglobally
Copy link

Starting QA

@isagoico
Copy link

isagoico commented Oct 15, 2021 •
edited
Loading

Checking off these PRs that were incorrectly added to the checklist:

  1. Refactor workspace settings #5642
  2. Fix invite page not loading after creating new workspace #5729
  3. Fix output currency #5749
  4. Set loading to false when requestorStep is submittted #5763
  5. Do not always clear Onyx VBA data when accessing workspace sections #5771
  6. [N6] Use AddressSearch for identity form #5770
  7. Show growl when clicking on links in offline mode #5776
  8. Close sidebar when going to concierge chat #5779
  9. Only show fancy loading page when we are submitting verifications #5787
  10. Prevent tappable bank account in EnableStep #5796
  11. [CP-stag] Get CompanyAddress field to autofill and show errors #5800
  12. Open OldDot links on Safari #5802
  13. Don't dismiss the Reimbursement Account Page after validating a withdrawal account #5803
  14. Fix link to OldDot's reports page #5813
  15. Use showStates in report params so that report state filters work in OldDot #5829
  16. Close AddressSearch results on blur #5832
  17. Only accept "address" result from google API - validate address_components before using it #5854
  18. Load policy list when url from Linking.getInitialURL is not available #5868

@kevinksullivan
Copy link
Contributor

These are on prod so I think we can safely check em off!

@isagoico
Copy link

Regression is finished!
Issues found:

  1. Tooltip not displayed in Workspace name  #5907 - Failing Added tooltip for workspace name #5812
  2. Date and state labels are overlapping with input content and placeholder #5904 - Failing Change State field in Company Info to 'Incorporation state' #5748
  3. [HOLD for payment 2021-10-30] Log in - Promo Colors are changing each time the user writes a new character for new password #5912 - Caused by Updates NewDot homepage to reflect N6 campaign #5318

Internal QA - #5703

Thanks!

@MelvinBot MelvinBot added the Monthly KSv2 label Oct 18, 2021
@roryabraham
Copy link
Contributor

#5812 is being redeployed here please retest. Only needs QA on web + desktop.

@mvtglobally
Copy link

mvtglobally commented Oct 18, 2021 •
edited
Loading

@roryabraham
Desktop/Web are pass
Screen Shot 2021-10-18 at 7 55 26 PM

@isagoico
Copy link

Retest for #5912 and #5913 were a pass 🎉 Checking them off

@isagoico
Copy link

The deploy blocker label was removed in this issue, not sure if this was intended #5904 CC @MariaHCD @Gonals. Are we good to check it off?

@MariaHCD
Copy link
Contributor

PR for #5904 is currently under review. I don't think the issue should block deploy so I believe we're good to check it off.

@roryabraham
Copy link
Contributor

PR to fix #5904 is being CP'd in 1.1.8-5 here. Please retest once deployed 😄

@isagoico
Copy link

Retest for #5923 (comment) was a pass on all environments except iOS (iOS test is missing since build failed)

@roryabraham
Copy link
Contributor

#5703 was merged into a feature branch which is already on production, so I'm going to check it off the checklist here.

@roryabraham
Copy link
Contributor

Welcome to the new format for the deploy checklist!

@isagoico
Copy link

@roryabraham Nice! This looks great! I see the accessibility checks were left unchecked. Will this checklist be tested on accessibility too? Not sure if the accessibility team has been notified CC @ogumen

@ogumen
Copy link

ogumen commented Oct 21, 2021

Thanks @isagoico, looking into them

@roryabraham
Copy link
Contributor

I think the plan for now is to not block deploys on any accessibility issues, so @ogumen feel free to perform accessibility testing on this, but there's a good chance I'll be checking off all those boxes pretty soon here so I can deploy all this code to production.

@ogumen
Copy link

ogumen commented Oct 22, 2021

@roryabraham all the accessibility checks have been performed, comments added to the corresponding PRs. I have also checked off the ones that were not applicable/verifiable for us.

@roryabraham
Copy link
Contributor

roryabraham commented Oct 22, 2021 •
edited
Loading

PR to fix #5920 was just merged and will be CP'd to staging in 1.1.8-9.

Edit: 1.1.8-9 is being deployed here 🕐

@roryabraham
Copy link
Contributor

PR to fix #5924 was verified on all platforms in 1.1.8-8, checking it off on the checklist.

@roryabraham
Copy link
Contributor

@isagoico @mvtglobally https://github.com/Expensify/App/actions/runs/1374067564 is almost done deploying ... I verified it on staging web but can you please test it on other platforms as well? Once it passes QA we are good-to-go here.

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@MariaHCD @MelvinBot @kevinksullivan @applausebot @mvtglobally @isagoico @roryabraham @OSBotify @ogumen