Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2021-10-23 #6017

Closed
OSBotify opened this issue Oct 23, 2021 · 22 comments
Closed

Deploy Checklist: New Expensify 2021-10-23 #6017

OSBotify opened this issue Oct 23, 2021 · 22 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Oct 23, 2021 •
edited by roryabraham
Loading

Release Version: 1.1.10-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@roryabraham
Copy link
Contributor

There are many PRs that were added to this checklist that should not have been. This PR is a likely culprit. cc @stitesExpensify @Julesssss

@roryabraham roryabraham added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Oct 25, 2021
@roryabraham
Copy link
Contributor

Actually I'm unlocking this again real quick just to test #6047, which will not affect the app itself at all.

@isagoico
Copy link

@roryabraham Just to confirm, we're good to start QA now right? Not sure if you finished the testing from last night 😬 (All slots are setup on our side so we just need the 🟢 light to add the lock label)

@roryabraham
Copy link
Contributor

Glad you asked first, finishing up testing now...

@roryabraham
Copy link
Contributor

Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

@roryabraham roryabraham added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Oct 26, 2021
@roryabraham
Copy link
Contributor

🟢

@isagoico
Copy link

Nice, good to go! The accessibility checkboxes will now be preserved, and any PRs w/ the [No QA] prefix in the title will automatically be checked off 👍

Beautiful 🥺 seems small but this will actually will make the PRs setup a lot easier! thanks a lot 🙇‍♀️

@MelvinBot MelvinBot added the Monthly KSv2 label Oct 26, 2021
@roryabraham
Copy link
Contributor

#5955 Passed internal QA and has no accessibility testing needed, checking it off.

@isagoico
Copy link

Regression is almost finished! Posting a summary of what has been found:

Issues found:

  1. The field border is not red while the error "Please provide a valid Phone Number" is shown on the bottom page  #6071 - Closed 🎉 (was found while executing Added minimum phone number length #5938)
  2. Desktop - Blank screen appears when exiting the onfido page in IOU flow #6082
  3. Split bill - Text is distorted in Spanish #6078
  4. Split bill - When writing a comment, Who paid gets hidden #6077
  5. Web - Attachment - No magnifying glass seen when hoovered over image in chat #6075
  6. [HOLD for payment 2021-11-29] ipad - Signin - Blank color startup page appears in sign in screen #6070

PRs left:

Thanks!

@nickmurray47
Copy link
Contributor

@isagoico Navigate to the Enable Payments Flow from within the Send Money Flow #5928 has a bug in it and I'm planning to deploy a fix to Staging

@roryabraham
Copy link
Contributor

Since Send Money is still behind a beta, I'm going to check off #6082 – it got demoted from deploy blocker to regular bug.

@roryabraham
Copy link
Contributor

#6086 has been fully deployed to staging, please QA it

@isagoico
Copy link

I drafted a message that the regression was done a while ago and didn't hit comment.

Regression is finished!

One last issue was raised here #6085

QAd PRs have been checked off.

@isagoico
Copy link

#6086 was a pass! Checking it off 🎉

@roryabraham
Copy link
Contributor

#6085 is fixed, checking it off 🎉

@roryabraham
Copy link
Contributor

It seems like the following PRs still need QA:

@isagoico
Copy link

My bad I must have missed checking off #4270. For #5828 I left a comment here, we were unable to verify step number 10 (https://expensify.slack.com/archives/C9YU7BX5M/p1635357929037000)

@roryabraham
Copy link
Contributor

Oof, looks like we've got a new blocker: #6097

@marcaaron
Copy link
Contributor

Tested internally and checking off #5828

@roryabraham
Copy link
Contributor

Solution to the last blocker is being deployed in 1.1.10-2 here.

@roryabraham
Copy link
Contributor

Confirmed #6097 is fixed in 1.1.10-2

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@MelvinBot @nickmurray47 @marcaaron @applausebot @isagoico @roryabraham @OSBotify