[HOLD for payment 2023-01-23] [$4000] mWeb - Copy to email/URL is not working correctly - reported by @mateusbra

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue was found when executing #8195

Action Performed:

1. Log in on New Expensify.
2. Open a report.
3. Type an URL and an e-mail on chat.

Expected Result:

The message "Copy e-mail to clipboard" displayed when you try to copy an email and "copy URL to clipboard" tapping URL

Actual Result:

The message "Copy to clipboard" displayed when you try to copy an email. Sometimes it shows as regular context menu

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Mobile Web

Version Number: 1.1.46-0

Reproducible in staging?: y

Reproducible in production?: y (New feature)

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5505102_Record_2022-03-25-00-35-55__1_.mp4

screen-20220324-194533.mp4

Expensify/Expensify Issue URL:

Issue reported by: Reported by @mateusbra https://expensify.slack.com/archives/C01GTK53T8Q/p1647474115298459

Slack conversation:

View all open jobs on GitHub
Issue was found when executing #8195

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a8294a9c054ef83d
• Upwork Job ID: 1595258571112300544

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mateusbra]

@kavimuru I found this issue while working on #8195 and reported on slack here: https://app.slack.com/client/T03SC9DTT/C01GTK53T8Q does that count for reporting bounty?

[kavimuru]

@mateusbra I don't have access to the slack. But as per this comment, #8195 (comment) yes. Also tester can repro this bug too #8006 (comment)

[johnmlee101]

Opening this up!

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[johnmlee101]

This should stay daily priority

[michaelhaxhiu]

@mateusbra do you have interest in working on this one since you discovered it? Feel free to leave a proposal if so.

@kavimuru can you please make sure we at the "@ reported by" to a GH title if they are due the bug reporting bounty? Seems applicable in this case for @mateusbra but maybe I'm not understanding fully?

[MelvinBot]

@Christinadobrzyn Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

Sorry for the delay, i was ooo. Posted job to Upwork;

Internal job - https://www.upwork.com/ab/applicants/1508625903649284096/job-details
External job - https://www.upwork.com/jobs/~01bd32eda238a19082

It does look like @mateusbra found/reported this issue so added them to the OP as the reporter.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @marcochavezf (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[zamarlancer]

Hi,
This is Zamar from Upwork.com
I will fix the issue by implementing URL parsing feature in ContextMenuAction.
Now there is no checking parts for url/email when the context menu is shown.
So there will be a validation for the clipboard text, which will check if it is an email address or an url; and switch the caption of the menu item according to the result.
Thank you.

[parasharrajat]

I don't see how this is different from #8195. This should have been fixed on #8311. cc: @Santhosh-Sellavel @mateusbra

why do we need a different issue?

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.54-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix context menu when long press on url and email link #12987

If no regressions arise, payment will be issued on 2023-01-23. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter @mateusbra
• Contributor that fixed the issue @b1tjoy
• Contributor+ that helped on the issue and/or PR @parasharrajat

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@marcochavezf] The PR that introduced the bug has been identified. Link to the PR: According to this message, this issue was introduced here.
• [@marcochavezf] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: The previous message contains the details about the regression.
• [@marcochavezf] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This issue already had a long discussion and the consensus about what solution to take wasn't clear several times, so I think the best way to prevent this issue in the future is to add regression tests to TR.
• [@arielgreen] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[arielgreen]

@marcochavezf @parasharrajat @b1tjoy please see and complete checklist

[parasharrajat]

Note: I haven't reviewed the PR for this issue due to unavailability.

[arielgreen]

Touching base with @marcochavezf here.

[marcochavezf]

Completed the BugZero checklist 👍🏽

[arielgreen]

still discussing

[arielgreen]

Payments issued.

No regression test needed, it's already covered here.

[parasharrajat]

Am I eligible for partial C+ payment(maybe 50% or 25%) on this issue?

Why?

1. Complexity for this issue was higher.
2. Proposals were reviewed.
3. It took extensive analysis and discussions to come up with the final proposal.

Why not?

1. PR was not reviewed by C+ [HOLD for payment 2023-01-23] [$4000] mWeb - Copy to email/URL is not working correctly - reported by @mateusbra #8311 (comment). I was on a family vacation and couldn't spare time for it.

cc: @marcochavezf @arielgreen

[parasharrajat]

Sorry for bumping this very old issue. Any comments on #8311 (comment)

cc: @marcochavezf @arielgreen