Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hold] Chat - Attachments thumbnail becomes blank for a moment in the preview when loading spinner appears #8501

Closed
kavimuru opened this issue Apr 5, 2022 · 18 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Apr 5, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/[](javascript:)
  2. Log in with any account
  3. Click on Plus button
  4. Attach any picture

Expected Result:

Attachment is visible all the time while uploading

Actual Result:

Attachment is blank for a moment while uploading

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Mobile Web

Version Number: 1.1.51.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5521419_Bug5521298_Screen_Recording_20220405-163952_Chrome.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 5, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

@johnmlee101 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2022
@johnmlee101 johnmlee101 added Monthly KSv2 and removed Overdue labels Apr 11, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2022
@johnmlee101
Copy link
Contributor

Whoops didn't mean to remove Overdue directly

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2022
@johnmlee101
Copy link
Contributor

This seems like a minor issue that we could open up to be fixed. The issue is when we switch the local version of the photo to the uploaded version. We should make sure its ready to be fully rendered before removing the thumbnail and spinner.

@johnmlee101 johnmlee101 removed their assignment Apr 11, 2022
@johnmlee101 johnmlee101 added the External Added to denote the issue can be worked on by a contributor label Apr 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@johnmlee101 johnmlee101 removed the Daily KSv2 label Apr 11, 2022
@melvin-bot melvin-bot bot removed the Monthly KSv2 label Apr 11, 2022
@thesahindia
Copy link
Member

thesahindia commented Apr 11, 2022

I think we won't need this after #8590 gets fixed

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 12, 2022
@JmillsExpensify
Copy link

Let's go ahead and put a hold on it then, and if it can't be reproduced in testing once #8590 goes live, we can close.

@JmillsExpensify JmillsExpensify changed the title Chat - Attachments thumbnail becomes blank for a moment in the preview when loading spinner appears [Hold] Chat - Attachments thumbnail becomes blank for a moment in the preview when loading spinner appears Apr 13, 2022
@JmillsExpensify
Copy link

Keeping open until the related issue gets further along in the PR process.

@JmillsExpensify
Copy link

All the action is still in #8590

@JmillsExpensify
Copy link

Still working out linked issue above.

@JmillsExpensify
Copy link

Contributor hired in the linked issue above.

@JmillsExpensify
Copy link

Still working through the considerations in the linked issue.

@JmillsExpensify
Copy link

Same same in the linked issue. I'm still keeping a weekly on this one since we've landed at C+ PR review.

@JmillsExpensify
Copy link

Still discussing in the linked issue.

@JmillsExpensify
Copy link

Great discussion in the linked issue, still going.

@JmillsExpensify
Copy link

@michaelhaxhiu Looks like #8590 is in production now and nearly through the hold for the regression period. What do you think about taking this issue now? Did we end up resolving this, or should we take this issue off hold?

@michaelhaxhiu
Copy link
Contributor

@JmillsExpensify nice timing 😃 .

Ok so - this is actually an obsolete bug report now, as far as I can see! The fix in #8590 changed the behavior of uploading images and now we don't show a blank white screen. This PR fix has some videos of uploads to demonstrate.

I think we can close this now!

@JmillsExpensify
Copy link

Nice to see we ended up resolving! I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Monthly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants