-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hold] Chat - Attachments thumbnail becomes blank for a moment in the preview when loading spinner appears #8501
Comments
Triggered auto assignment to @johnmlee101 ( |
@johnmlee101 Eep! 4 days overdue now. Issues have feelings too... |
Whoops didn't mean to remove Overdue directly |
This seems like a minor issue that we could open up to be fixed. The issue is when we switch the local version of the photo to the uploaded version. We should make sure its ready to be fully rendered before removing the thumbnail and spinner. |
Triggered auto assignment to @JmillsExpensify ( |
I think we won't need this after #8590 gets fixed |
Let's go ahead and put a hold on it then, and if it can't be reproduced in testing once #8590 goes live, we can close. |
Keeping open until the related issue gets further along in the PR process. |
All the action is still in #8590 |
Still working out linked issue above. |
Contributor hired in the linked issue above. |
Still working through the considerations in the linked issue. |
Same same in the linked issue. I'm still keeping a weekly on this one since we've landed at C+ PR review. |
Still discussing in the linked issue. |
Great discussion in the linked issue, still going. |
@michaelhaxhiu Looks like #8590 is in production now and nearly through the hold for the regression period. What do you think about taking this issue now? Did we end up resolving this, or should we take this issue off hold? |
@JmillsExpensify nice timing 😃 . Ok so - this is actually an obsolete bug report now, as far as I can see! The fix in #8590 changed the behavior of uploading images and now we don't show a blank white screen. This PR fix has some videos of uploads to demonstrate. I think we can close this now! |
Nice to see we ended up resolving! I'll close. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Attachment is visible all the time while uploading
Actual Result:
Attachment is blank for a moment while uploading
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.51.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5521419_Bug5521298_Screen_Recording_20220405-163952_Chrome.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: