Deploy Checklist: New Expensify 2022-04-20

[yuwenmemon]

Release Version: 1.1.56-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add slash in Debit card expiration #7362

  • QA
  • Accessibility

• Fix/nested scroll views google places api #8256

  • QA
  • Accessibility

• Workspace - Workspace name is not fully visible under all Workspace Settings #8341

  • QA
  • Accessibility

• ignore periods on search #8375

  • QA
  • Accessibility

• [Fix] Prevent fade on scroll #8386

  • QA
  • Accessibility

• Prevent re-order when active draft becomes empty #8397

  • QA
  • Accessibility

• Show empty policyExpenseChats in LHN just like defaultRooms #8476

  • QA
  • Accessibility

• merge getReportIcons and getAvatarSources functions #8499

  • QA
  • Accessibility

• Add title in unable to close account modal #8584

  • QA
  • Accessibility

• [fix 8289]: emoji isn't fully visible after editing #8585

  • QA
  • Accessibility

• make onfido page scrollable #8603

  • QA
  • Accessibility

• Don't exclude concierge from group chats #8604

  • QA
  • Accessibility

• Protect from potentially undefined function call #8626

  • QA
  • Accessibility

• [No QA] Stop sending undefined request params to the API #8639

  • QA
  • Accessibility

• Rename onChange to onInputChage in AddressSearch #8647

  • QA
  • Accessibility

• [No QA] Missing propType in SettlementButton #8649

  • QA
  • Accessibility

• Rename PersistedRequestsQueue make sequential #8650

  • QA
  • Accessibility

• fix bluebox showing when trying to open context menu #8672

  • QA
  • Accessibility

• Only set inputValues when undefined #8677

  • QA
  • Accessibility

• Remove policy default rooms when policy member is removed from policy #8684

  • QA
  • Accessibility

• Update cherryPick workflow message to clarify error state #8686

  • QA
  • Accessibility

• Announce cherrypick failure if PR mergability state is blocked #8688

  • QA
  • Accessibility

• Enable add payment method while payments load #8693

  • QA
  • Accessibility

• make the label smaller as it doesn't fit in the field #8694

  • QA
  • Accessibility

• Key fix for timezone #8695

  • QA
  • Accessibility

Deploy Blockers:

• LHN - List of user's conversation is not displayed in LHN #8709
• IOS/Android - The message about successful avatar change is duplicated #8729

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[mvtglobally]

@yuwenmemon Release Version: `` looks blank.

[yuwenmemon]

Updated! Should have been 1.1.56-0

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mvtglobally]

My bad, I was adding label on another ticket #8709. Its repro in Prod, but wasn't repro in the previous build

[mvtglobally]

@yuwenmemon just FYI. IOS did not deploy yet. We are working on other platforms right now, but maybe you can re-push the IOS build like yesterday if its stuck again?

[yuwenmemon]

Ah yes, it is stuck 😭

[yuwenmemon]

Trying it again.

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.56-0 🚀

[yuwenmemon]

Should be all good now!

[mvtglobally]

@yuwenmemon Regression is completed. Only 1 blocker maybe we can push for another deploy tomorrow?
Deploy Blocker #8729

PR #8256 is not working #8256 (comment) Since it same in PROD are we good to check off?
PR #8576 is failing for public account. Not sure if this is expected and we can check if off #8728
PR #8647 is not working #8256 (comment) Since it same in PROD are we good to check off?
PR #8650 is failing #8724. Since it same in PROD are we good to check off?

Issues logged
#8690
#8711
#8724
#8728
#8729
#8731
#8734
#8740
#8744

[mvtglobally]

#8709 is fixed. Checking off

[yuwenmemon]

@mvtglobally looks like there are still some items to check off like #8684, right?

[mvtglobally]

@yuwenmemon i think I missed to update it in the list.
#8684 is failing due to #8734 Its repro in prod. So probably not a blocker

Can I check off below PRs based on the comments above ?
PR #8256
PR #8576
PR #8647
PR #8650

[mvtglobally]

@francoisl checklist is all ready for you 😜

[francoisl]

#8684 is failing due to #8734 Its repro in prod. So probably not a blocker

Could you test that one again please? It depended on https://github.com/Expensify/Web-Expensify/pull/33568, which has been deployed to production, so I expect it should work now as Luke pointed out here too.

I'm looking at the other unchecked PRs in the meantime.

---

For the record, there's also 1 new, non-fatal crash report for 1.1.56-0 specifically on Firebase (here). The function causing the warning doesn't seem to have changed for this release and it's just one non-fatal occurrence, so I think it's safe to proceed.

[francoisl]

PR #8256
PR #8647

Looks like it's also happening on production for both, we can check them off.

PR #8576

This PR is still open, did you mean #8476 instead?

PR #8650

We can check this one off given the explanation in the PR that the issue you noticed is somewhat expected and not a blocker.

[mvtglobally]

@francoisl
Checking #8684 again. Will update shortly.
Checking off #8650, #8256, #8647

and yes, Typo, I meant #8476

[mvtglobally]

@francoisl are we ok to check off #8476?

We re-tested #8684 (comment). Not sure if this is acceptable or will block deploy?
These are the last 2 items pending

[francoisl]

I'm checking off #8476 as per the QA instructions and tagged the author.
For #8684, it seems like applause.expensifail.com is not on the required beta, so I don't think you'd be able to test now. I'm also not sure if we'd want to add the whole domain to that beta right now. Since the feature is only available behind a beta, I'm also leaning on checking this one off. I also tagged the PR's author to double check if it's working as intended.

So with that said, looks like we're good to go with the deploy!

[francoisl]

[SumitDiyora]

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8341, #8386, #8397, #8603, #8626, #8639, #8647, #8649, #8650, #8677, #8684, #8686, #8688, #8693
Logged Issues - #8393, #8395, #8400, #8465, #8392, #8560, #8432, #8555, #8398, #8385, #8385, #8400, #8560, #8465, #8432, #8392, #8393, #8395, #8398, #8465, #8430, #8432, #8398, #8616, #8406, #8407, #8407, #8418, #8395, #8400, #8393, #8395, #8434, #8433, #8413, #8432, #8651, #8430, #8465, #8417, #8463, #8413, #8432, #8433, #8434, #8651, #8465, #8430, #8432, #8433, #8392, #8393, #8577, #8560, #8555