Android - Signup - App crashes when creating a new account

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Enter any email address which does not have expensify account
3. Tap continue

Expected Result:

User is taken to magic link sent screen

Actual Result:

App crashed with message Uh -oh something went wrong!

Workaround:

unknown

Platform:

Where is this issue occurring?

• Android

Version Number: 1.1.70-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5592202_20220531_162926_1_.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[neil-marcellini]

The uploaded video doesn't show the bug, and I was unable to reproduce running on the simulator with the latest from main. I will ping #expensify-open-source to see if someone can reproduce this on an actual Android device.

Screen.Recording.2022-05-31.at.2.33.35.PM.mov

[rushatgabhane]

@neil-marcellini the bug is reproducible on a physical Android device (Pixel 6, Android 12)

v1.1.70-1 (Production, main and everything)
Fire here?

screen-20220601-004432.mp4

[neil-marcellini]

Cool, thanks @rushatgabhane. I think this should probably be internal since it might have to do with our API. I'll send it to the demolition team. I would take it myself if I had an android.

[melvin-bot]

Triggered auto assignment to @TomatoToaster (Demolition), see https://stackoverflow.com/c/expensify/questions/8099 for more details.

[mvtglobally]

@neil-marcellini. full video

Screen_Recording_20220531-163515_New.Expensify.mp4

[neil-marcellini]

I'm wondering if the error I'm seeing here is related?

[marcaaron]

I think I know the cause. Can someone please check to see if this exists on my branch here -> #9060

[rushatgabhane]

@marcaaron the issue exists on #9060

[rushatgabhane]

I'm wondering if the error I'm seeing #8855 (comment) is related?

@neil-marcellini yep, looks like it. I'm gettin the above error on signing up with a new acc

[luacmartins]

Ah this seems like this issue that I created this week - #9255. It's been happening for a while now. I'm gonna close that issue in favor of this one.

[TomatoToaster]

Haven't gotten a chance to start on this yet, planning to later today.

[TomatoToaster]

Still working on this one.

[TomatoToaster]

Ah I couldn't get it to work still going to make a PR for this 🔜

[TomatoToaster]

PR up for this but feels like a band-aid not a real solution. I'm not sure if there's a better solution to this. After investigating and trying to recreate this (hadn't been able to on emulator obviously) I think this should at least address the problem.

[marcaaron]

I looked at the linked solution, but it seems like it would briefly display something like Not ? instead of Not [email protected]? in the cases where it would previously crash. Maybe better to just show nothing.

[francoisl]

Reopening this since there was still an issue during the QA, see #9480 (comment) for context.

[TomatoToaster]

I looked at the linked solution, but it seems like it would briefly display something like Not ? instead of Not [email protected]? in the cases where it would previously crash. Maybe better to just show nothing.

I guess I could conditionally render the whole block if the props.credentials.login exists. I'll start with that, but I think this is a bandaid solution and will still likely cause the API error mentioned right above. I'm guessing the fact that props.credentials.login doesn't is causing the problem.

[aldo-expensify]

This has been fixed now.

See https://github.com/Expensify/Terraform/commit/3d54c66dcf97c1e72867a2dfee02a1177ce155c3 and #9564 (comment)

Summary: There is a special firewall for requests with command User_SignUp to prevent fraud. Requestw coming from Android have a poor bot score and we were denying them.