Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-06-01 #9275

Closed
27 tasks done
OSBotify opened this issue Jun 1, 2022 · 29 comments
Closed
27 tasks done

Deploy Checklist: New Expensify 2022-06-01 #9275

OSBotify opened this issue Jun 1, 2022 · 29 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

Release Version: 1.1.71-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@luacmartins luacmartins self-assigned this Jun 1, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 1, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 1, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.70-2 🚀

@luacmartins
Copy link
Contributor

luacmartins commented Jun 1, 2022

@kavimuru we reverted #9210 to fix #9280.

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 1, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.70-3 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 1, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.70-3 has been deployed to staging 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.70-4 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.70-4 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

@mvtglobally where are we on QA?

@mvtglobally
Copy link

@luacmartins i will update in a bit. Team is finishing Desktop slots post fix

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.70-5 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.70-5 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

Checkin off #9295 and #9299 since Desktop deploy is working 🎉

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.71-1 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 2, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.71-1 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

@mvtglobally any updates?

@mvtglobally
Copy link

Regression is completed @luacmartins

PR #9207 is failing due to #8797 and blocked on Android dues to #9263 checking off as both and not blockers

Issues logged

#9281
#9283
#9287
#9290

@SumitDiyora
Copy link

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9295, #9299
Logged Issues - #8618, #8624, #8406, #8407, #8400, #8398, #8395, #8393, #8392, #8624, #8432, #8433, #8411, #8624, #8580, #8579, #8575, #8578, #8577, #8618, #8614, #8484, #8575, #8577, #8703, #8633, #8624, #8479, #8478, #8527, #8392, #8400, #8398, #8393, #8624, #8434, #8433, #8478, #8624

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 3, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.71-2 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 3, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.71-2 has been deployed to staging 🎉

@mvtglobally
Copy link

@luacmartins Are we good to 🚀 ?

@luacmartins
Copy link
Contributor

@mvtglobally the checklist is clear but we won't deploy today because it's already Friday afternoon and we won't have enough time to deal with any potential issues. Deploys will resume on Monday morning!

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 5, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.71-3 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Jun 5, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.71-3 has been deployed to staging 🎉

@luacmartins
Copy link
Contributor

@yuwenmemon here's the current deploy checklist. I think it's mostly ready for deploy, but we did have a CP fail over the weekend, so you might wanna take a look at that first.

Here's the CP PR that needs to be fixed - #9317

@luacmartins luacmartins removed their assignment Jun 6, 2022
@AndrewGable
Copy link
Contributor

Feel free to ignore the CP @yuwenmemon - I sorted it

@mvtglobally
Copy link

Do we need to QA any additional CPs/PRs? All seem checked off in the list. Just double checking @luacmartins @AndrewGable @yuwenmemon

@AndrewGable
Copy link
Contributor

Does not seem like it to me, also I checked off the internal since it's passing here: #9291 (comment)

@luacmartins
Copy link
Contributor

I think we are good to ship it.

@yuwenmemon
Copy link
Contributor

Thanks @luacmartins and @AndrewGable for all your work last week!

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

7 participants