Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GithubUtils.getStagingDeployCashData() returned a deploy blocker issue in list of PRs #9500

Closed
francoisl opened this issue Jun 20, 2022 · 3 comments
Assignees
Labels
Daily KSv2 Reviewing Has a PR in review

Comments

@francoisl
Copy link
Contributor

Action Performed:

  1. We merged a pull request that had the CP staging label
  2. The action createOrUpdateStagingDeploy failed
Backup of the deploy checklist issue's markdown at the time of the error

**Release Version:** `1.1.78-0`
**Compare Changes:** https://github.com/Expensify/App/compare/production...staging

**This release contains changes from the following pull requests:**

- https://github.com/Expensify/App/pull/9031
  - [ ] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9266
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9347
  - [ ] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9401
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9404
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9445
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9460
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9462
  - [ ] QA
  - [ ] Accessibility

- https://github.com/Expensify/App/pull/9468
  - [x] QA
  - [x] Accessibility

- https://github.com/Expensify/App/pull/9473
  - [ ] QA
  - [ ] Accessibility


**Internal QA:**
- [x] https://github.com/Expensify/App/pull/9458 - @yuwenmemon @mountiny


**Deploy Blockers:**
- [ ] https://github.com/Expensify/App/issues/9487

**Deployer verifications:**
- [ ] I checked the [App Timing Dashboard](https://graphs.expensify.com/grafana/d/yj2EobAGz/app-timing?orgId=1) and verified this release does not cause a noticeable performance regression.
- [ ] I checked [Firebase Crashlytics](https://console.firebase.google.com/u/0/project/expensify-chat/crashlytics/app/android:com.expensify.chat/issues?state=open&time=last-seven-days&tag=all) and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

Expected Result:

#9487 should not have been returned in PRList by GithubUtils.getStagingDeployCashData().

Workaround:

Fix the deploy blocker, restart the deploy action

Platform:

Platform-independent

View all open jobs on GitHub

@francoisl francoisl added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jun 20, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 20, 2022

Triggered auto assignment to @JmillsExpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 20, 2022
@francoisl
Copy link
Contributor Author

Note that this is an issue with our Github deploy actions, but I think it should be able to be worked on externally too.

@roryabraham
Copy link
Contributor

Got a PR up to fix this.

@roryabraham roryabraham added the Reviewing Has a PR in review label Jun 21, 2022
@melvin-bot melvin-bot bot closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

3 participants