Deploy Checklist: New Expensify 2022-06-28

[OSBotify]

Release Version: 1.1.79-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Standardize arrow navigation in OptionsLists #7702

  • QA
  • Accessibility

• Fix: Request money - Five most recent chats aren't shown correctly #8549

  • QA
  • Accessibility

• Refactor ChangePassword #9218

  • QA
  • Accessibility

• Replace Report_AddComment with AddComment (Part 2) #9350

  • QA
  • Accessibility

• fix: autolink on edit #9405

  • QA
  • Accessibility

• [No QA] Fix mobile transitions for some emails #9469

  • QA
  • Accessibility

• PasswordFieldFix #9493

  • QA
  • Accessibility

• green outline showing on workspace avatar image #9507

  • QA
  • Accessibility

• Get the notification preference for all report types #9512

  • QA
  • Accessibility

• add focus indicator for emoji picker search field #9534

  • QA
  • Accessibility

• [No QA] update API.md with more general rules #9536

  • QA
  • Accessibility

• updating the expensify-common to latest #9549

  • QA
  • Accessibility

• Add debit card page - Save button isn't translated #9550

  • QA
  • Accessibility

• Update CONTRIBUTING.md #9553

  • QA
  • Accessibility

• Fix app crash on opening search page #9554

  • QA
  • Accessibility

• Update Onfido dependency to the latest version #9555

  • QA
  • Accessibility

• [No QA] update JSDoc for API.js functions #9558

  • QA
  • Accessibility

• Only show loading indicator while loading #9563

  • QA
  • Accessibility

• Remove PaymentMethod API call for Paypal modal #9569

  • QA
  • Accessibility

• Revert to version 1.6.13 to fix actionlint regression #9574

  • QA
  • Accessibility

• Double max participant message fix #9610

  • QA
  • Accessibility

• [No QA] Create composite action to set up git for OSBotify #9619

  • QA
  • Accessibility

• Scroll to the top when new options are selected on multiple-selection screens #9626

  • QA
  • Accessibility

• Allow free policies to have their default rooms be shown #9632

  • QA
  • Accessibility

• [No QA] Use uuid to generate branch name in updateProtectedBranch #9639

  • QA
  • Accessibility

• [No QA] Wait for checks to complete before giving up due to mergeable_state blocked #9643

  • QA
  • Accessibility

• Make CMD+Enter work for single-selection pages #9672

  • QA
  • Accessibility

• Fix off-by-one error in scrollToIndex #9674

  • QA
  • Accessibility

• Fix ArrowKeyFocusManager for lists with only two options #9682

  • QA
  • Accessibility

• Revert "Fix off-by-one error in scrollToIndex" #9690

  • QA
  • Accessibility

• Fix OptionsSelector crash #9714

  • QA
  • Accessibility

Deploy Blockers:

• [$250] Web - IOU Participants - Nothing happens when press CMD+Enter #9594
• Split/Group - Selected user is not visible for split bill/create a group chat #9598
• New group- Text for the maximum number (8) of participants is repeated twice #9606
• IOU- Missing bullets after clicked on the currency symbol  #9614
• Web - New Group - Crash when deleting digits in a search query for specific accounts #9671
• Web - Group Chat - Using Enter key is leaded for crash  #9685
• Search - Focus moves to the 1st line of results when the search query #9695

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.79-2 🚀

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.79-3 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.79-3 has been deployed to staging 🎉

[mvtglobally]

@sketchydroide Regression is completed
Deploy Blockers
#9598
#9606
#9614

PR #7702 is failing due to multiple issues #9594, #9606, #9598
PR #9512 (comment) need clarification. We are blocked to proceed as There is no settings in workspace as in the video attached in the PR
PR #9469 we are not able to execute on native app or mWeb. Is it ok to check off? #9469 (comment)

Issues logged
#9594
#9595
#9605
#9608
#9620

[sketchydroide]

#9606 has been fixed
#9614 is not a blocker.
Following up on #9598

[sketchydroide]

added #9594 as a deploy blocker as it blocks the test of #7702, and until we understand what is needed it should have maximum attention.

[roryabraham]

Checked off #9594 and #9614 as they're not deploy blockers.

#9606 should be fixed by #9610, but the CP failed. Just manually merged it so that fix should be deployed soon

[roryabraham]

All GH Actions are currently down, so merging that failed CP did not result in a deploy. We'll just need to wait for the GH incident to be resolved, then we will evaluate. We probably will need to manually CP the PR again.

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[sketchydroide]

#9598 is not a deploy blocker, @roryabraham just confirmed this.

[sketchydroide]

I've answered #9469 (comment) comment

[sketchydroide]

@mvtglobally please give an email for me to add to the policyExpenseChat beta, I'm not sure if I should add all of the expensifails at the moment.
This is for #9512

[mvtglobally]

@sketchydroide add [email protected] & [email protected]

[mvtglobally]

Checking off #9469 (comment)
#7702 & #9512 are the only 2 outstanding PRs

[sketchydroide]

@sketchydroide add [email protected] & [email protected]

Done, it might take a few minutes for this to be in effect

[sketchydroide]

@roryabraham what can we do to unblock #7702?
Is it the manual merge thing?

[roryabraham]

@roryabraham what can we do to unblock #7702?

Sorry, @mvtglobally why is #7702 blocked?

[mvtglobally]

@sketchydroide #9512 is a pass. Checking off

@roryabraham there were couple of blockers for #7702 (#9594, #9606) But seems like they are resolved. there are other issues which are not blockers. We didn't retest any new CPs. Not sure if we need to.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.79-7 🚀

[roryabraham]

Checked off #9598 because it's not a deploy blocker.

[roryabraham]

@Expensify/applauseleads can we do some retesting please:

• Double max participant message fix #9610 should be fixed in v1.1.79-3+. I verified the fix on web.
• Allow free policies to have their default rooms be shown #9632 was CP'd in v1.1.79-5 and has some QA steps to run
• If necessary, run through the QA for Standardize arrow navigation in OptionsLists #7702. The few issues that propped up so far were either not blockers or mistakes in my QA steps

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.79-7 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.79-9 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.79-9 has been deployed to staging 🎉

[sketchydroide]

@Expensify/applauseleads I think this is ready to be tested again, a few more that need to be QA but I think all the stuff that was blocked has been fixed

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[roryabraham]

Oh, actually now that Web-E is deployed we need to run QA on #9350

[Julesssss]

CC @Expensify/applauseleads

Oh, actually now that Web-E is deployed we need to run QA on #9350

[trjExpensify]

How we looking here, ya'll?

[roryabraham]

@trjExpensify You can follow along in slack here

[roryabraham]

Looks like the only issue that popped up was #9766. While it looks like a legitimate bug, I'm thinking we should not treat it as a blocker because it's pretty minor and we have a pressing need to get this release out the door. Thoughts?

[roryabraham]

Actually, #9766, is reproducible in production. So it's definitely not a blocker

[roryabraham]

Following confirmation in slack, #9350 passed without any blockers, so I'm going to check it off.

[roryabraham]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[roryabraham]

Oh, #9626 had some issues but no blockers. Checking that off as well.

[roryabraham]

[roryabraham]

Need to reopen this due to a failed deploy workflow

[roryabraham]

#9771 should fix NewDot deploys 🤞

[roryabraham]

#9771 merged. Let's try this again, shall we?

[roryabraham]

[roryabraham]

Not quite

[roryabraham]

Going to ship this again. I think the staging deploy + new checklist creation should happen automatically 🤞, but I'll need to manually do the production deploy. Slack context here

[roryabraham]

[Julesssss]

Thanks @roryabraham!