Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate unnecessary deploys and noise from help site PRs #9761

Closed
roryabraham opened this issue Jul 7, 2022 · 1 comment
Closed

Eliminate unnecessary deploys and noise from help site PRs #9761

roryabraham opened this issue Jul 7, 2022 · 1 comment
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

Problem

When help site PRs are merged, they are subjected to the same CI/CD as the rest of the repo. This means that they:

  1. May trigger NewDot deploys
  2. Will get inaccurate/misleading deploy comments
  3. Will cause unnecessary noise in GitHub and slack

Why this is important

It will be a distraction and waste people's time. It's also just annoying

Solution

Skip most NewDot CI/CD if a merged PR only changes files under the /docs directory.

@roryabraham roryabraham added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels Jul 7, 2022
@roryabraham roryabraham self-assigned this Jul 7, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 15, 2022
@roryabraham
Copy link
Contributor Author

Going to close this in favor of #9725

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant