-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript #39206
[No QA] Migrate 'OptionsListUtilsTest.js', 'DateUtilsTest.js', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript #39206
Conversation
…', 'SidebarLinks.perf-test.js', 'markdown.js' and 'ReportUtilsTest.js' to Typescript" This reverts commit 39aaa56.
@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
if ('baseline' in entry && 'current' in entry) { | ||
return format.formatDurationDiffChange(entry); | ||
formattedDuration = format.formatDurationDiffChange(entry); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a bit more verbose, wondering why we needed this vs what we had before, did TS complain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youssef-lr Yeah, TS complained before!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's test it before we merge this time 😅
…25312-25313-to-typescript
@youssef-lr can you review this again and check that it's working so that we can merge this? Thanks 😄 |
…s failing because of daylight saving time
…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts # tests/unit/OptionsListUtilsTest.ts
…25312-25313-to-typescript
@youssef-lr Kind bump 💌 |
@pac-guerreiro we have merge conflicts |
…25312-25313-to-typescript # Conflicts: # src/libs/OptionsListUtils.ts
@fabioh8010 @blazejkustra @youssef-lr merge conflicts resolved! |
@youssef-lr all yours! |
Testing now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@pac-guerreiro conflicts sorry :/ I was not feeling well past few days apologies for the delay |
…25312-25313-to-typescript
@youssef-lr @fabioh8010 conflicts resolved, have fun! 😄 |
@youssef-lr Here is not showing any conflicts 🤔 |
Ok I was able to merge from mobile. Not sure why on desktop it was stuck like that. |
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.61-0 🚀
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.4.61-0 🚀
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀
|
Details
The original PR had to be reverted because it introduced errors on main.
Fixed Issues
$ #25309 #25310 #25311 #25312 #25313
PROPOSAL: N/A
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
N/A
Android: mWeb Chrome
N/A
iOS: Native
N/A
iOS: mWeb Safari
N/A
MacOS: Chrome / Safari
N/A
MacOS: Desktop
N/A