From ae5e3ae9ed6eb7353cc2cff730481d2f3b9b1359 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 11 Jul 2024 16:44:11 +0200 Subject: [PATCH 1/2] e2e: properly count re-renders in typing test --- .../ComposerWithSuggestions/index.e2e.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx index 682d3e8605b9..01180bdf4c40 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx @@ -18,6 +18,12 @@ function IncrementRenderCount() { } function ComposerWithSuggestionsE2e(props: ComposerWithSuggestionsProps, ref: ForwardedRef) { + "use no memo"; + + // we rely on waterfall rendering in react, so we intentionally disable compiler + // for this component. This file is only used for e2e tests, so it's okay to + // disable compiler for this file. + // Eventually Auto focus on e2e tests useEffect(() => { const testConfig = E2EClient.getCurrentActiveTestConfig(); From 47a13fe843812f99dc1649dfe5b3619cb7e176d5 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 11 Jul 2024 17:21:07 +0200 Subject: [PATCH 2/2] fix: prettier --- .../ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx index 01180bdf4c40..beebccd131b3 100644 --- a/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx +++ b/src/pages/home/report/ReportActionCompose/ComposerWithSuggestions/index.e2e.tsx @@ -18,7 +18,7 @@ function IncrementRenderCount() { } function ComposerWithSuggestionsE2e(props: ComposerWithSuggestionsProps, ref: ForwardedRef) { - "use no memo"; + 'use no memo'; // we rely on waterfall rendering in react, so we intentionally disable compiler // for this component. This file is only used for e2e tests, so it's okay to