Update react-native-onyx to reduce setState() calls / renders in withOnyx

[marcaaron]

Details

Context is in the linked issue. This PR implements the changes introduced here.

Fixed Issues

$ #4592 (comment)

Tests

The tests I performed were:

1. Profile the web app's initial load and inspect the time immediately preceding the FCP
2. Observed the scripting time
3. Repeated the test with this branch
4. Observed a reduction in scripting time

QA Steps

No QA

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcaaron]

Confused, is this on staging or not...? OSBotify says no and it's not on the staging branch - but is referenced on the Deploy Checklist. Oh I see it was added incorrectly maybe... #4554 (comment)

Regardless, we found an issue with this and are fixing it here: #4676

I'm unsure if the new PR should be CP'd to staging. I think not - unless this once moves to staging first and then maybe it should? 🤷

[OSBotify]

🚀 Deployed to staging by @marcaaron in version: 1.0.85-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[isagoico]

Removing and re adding the deploy blocker label so the PR is added to the checklist. @marcaaron This PR is now on staging

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.0.86-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅