-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257
Draft
mateuuszzzzz
wants to merge
57
commits into
Expensify:main
Choose a base branch
from
software-mansion-labs:make-new-dot-signin-default-for-hybridapp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[HybridApp] Implement POC of NewDot SignIn on HybridApp #51257
mateuuszzzzz
wants to merge
57
commits into
Expensify:main
from
software-mansion-labs:make-new-dot-signin-default-for-hybridapp
+374
−128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnowakow
reviewed
Oct 31, 2024
# Conflicts: # src/libs/actions/Session/index.ts
…ult-for-hybridapp
* Implement ND bootsplash logic * Rename param * Adress review
# Conflicts: # src/ONYXKEYS.ts # src/libs/actions/Session/index.ts # src/types/modules/react-native.d.ts
* Add hybridAppSettings AppProp * Unify how we pass data on both platforms * fix after merge * fix comments --------- Co-authored-by: war-in <[email protected]>
* wip * block switching when error returned * make goBack work correctly * validate code form and SignIn button works (but require further investigation) * show error when unable to switch to OD * adjust new sign-up flow * add comment --------- Co-authored-by: war-in <[email protected]>
# Conflicts: # src/components/InitialURLContextProvider.tsx # src/libs/actions/Session/index.ts
* Simplify HybridApp.ts * Use early returns * Rearrange HybridApp module * Remove redundant keys * Remove unused import
* Simplify HybridApp.ts * Use early returns * Rearrange HybridApp module * Remove redundant keys * Remove unused import * Refactor remaining parts of code * Do not init with useEffect * Remove console.debug * Reduce repeating code * Remove unused import * reset sign-in logic on sign out --------- Co-authored-by: war-in <[email protected]>
Co-authored-by: war-in <[email protected]>
…hybridapp' into make-new-dot-signin-default-for-hybridapp
# Conflicts: # src/libs/Navigation/AppNavigator/AuthScreens.tsx # src/libs/Navigation/AppNavigator/PublicScreens.tsx
# Conflicts: # src/libs/API/types.ts
# Conflicts: # src/ONYXKEYS.ts # src/hooks/useOnboardingFlow.ts # src/pages/settings/InitialSettingsPage.tsx # src/types/onyx/index.ts
* wip * wip * remove comment * clean * remove unused parameters and fix sign up flow * block sign in logic when OD sign-in was performed * simplify blocking logic * fix crash when switching apps * Fix bug where OpenApp is called after opening app from background --------- Co-authored-by: war-in <[email protected]> Co-authored-by: Mateusz Rajski <[email protected]>
* make HybridAppModule methods readable * improve another method --------- Co-authored-by: war-in <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
OldDot PR: https://github.com/Expensify/Mobile-Expensify/pull/13284
Fixed Issues
$ #49844
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop