fix: display all LHN options in Import state mode #53374

TMisiukiewicz · 2024-12-02T11:01:29Z

Explanation of Change

When using Import Onyx state, for some users LHN list does not display all items comparing to the original account. This is because session key in Onyx is not overriden, and if the accountID does not exist in the personalDetails, it doesn't display all the items. This PR overrides session and keeps the original one in a separate key until the app is not returned into the orignal state.

Fixed Issues

$ #53060
PROPOSAL:

Tests

Go to Settings -> Troubleshoot
Export Onyx state
Log out and log into another account (ideally create an entirely new account)
Go to Settings -> Troubleshoot
Press Import Onyx state and select the exported file
Wait until the file loads
Verify the LHN have all the items comparing to the original account

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

TMisiukiewicz · 2024-12-02T11:01:57Z

Opening as a draft first as it is blocked by #53370

melvin-bot · 2024-12-11T14:36:45Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

TMisiukiewicz · 2024-12-11T14:37:08Z

marking as ready for review as blocking PR is now merged

jjcoffee · 2024-12-11T15:17:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2024-12-12_17.06.46.mp4

Android: mWeb Chrome

android-chrome-2024-12-12_17.10.01.mp4

iOS: Native

ios-app-2024-12-12_17.28.34.mp4

iOS: mWeb Safari

ios-safari-2024-12-12_17.31.41.mp4

MacOS: Chrome / Safari

desktop-chrome-2024-12-12_17.11.02.mp4

MacOS: Desktop

desktop-app-2024-12-12_17.14.50.mp4

jjcoffee · 2024-12-11T15:19:38Z

@TMisiukiewicz Would it be worth adding a unit test for this? Also, would you mind adding a screenrecording for iOS Safari for completeness? 🙏

jjcoffee

Just a couple of comments to address.

TMisiukiewicz · 2024-12-13T06:40:38Z

Would it be worth adding a unit test for this?

I added some unit tests for transforming imported data

Also, would you mind adding a screenrecording for iOS Safari for completeness?

after updating Xcode I have problems with Safari on iOS and it crashes each time I try to open any website, already tried everything and couldn't find a solution for that 😕 I guess I have to wait for another update...

Also, not sure if this is related to this PR but the import loader also stops too soon (when I switch to the LHN you can see that the import is still pulling in reports).

~~We have an umbrella issue for Import/Export fixes #53060 so I'll tackle it in a separate PR :)~~

Actually it looks like fixing it in this PR is beneficial because it'll prevent moving to a main screen until the data is fully loaded. Let's fix it here then :)

I'm taking a look on the issue with user data not appearing now.

TMisiukiewicz · 2024-12-13T08:32:40Z

@jjcoffee ready for review ✅

…-when-importing-state

jjcoffee

LGTM! Thanks for the quick fixes 🙏

OSBotify · 2024-12-13T11:49:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-13T16:03:18Z

🚀 Deployed to staging by https://github.com/Gonals in version: 9.0.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

TMisiukiewicz added 4 commits November 21, 2024 15:20

override session of the user

7fa7e1f

Merge branch 'main' into fix/store-accountid-when-importing-state

8a2e7d6

Merge branch 'main' into fix/store-accountid-when-importing-state

bb668cb

Merge branch 'main' into fix/store-accountid-when-importing-state

2ca1514

Merge branch 'main' into fix/store-accountid-when-importing-state

fde7037

TMisiukiewicz marked this pull request as ready for review December 11, 2024 14:36

TMisiukiewicz requested a review from a team as a code owner December 11, 2024 14:36

melvin-bot bot requested a review from jjcoffee December 11, 2024 14:36

melvin-bot bot removed the request for review from a team December 11, 2024 14:36

This comment was marked as resolved.

Sign in to view

jjcoffee suggested changes Dec 12, 2024

View reviewed changes

add unit tests for import onyx state

531b937

TMisiukiewicz added 2 commits December 13, 2024 09:05

preserve user session on mobile

47aae42

navigate to homescreen when onyx state is fully set

981ee0d

Merge remote-tracking branch 'upstream/main' into fix/store-accountid…

5265dc6

…-when-importing-state

jjcoffee approved these changes Dec 13, 2024

View reviewed changes

melvin-bot bot requested a review from Gonals December 13, 2024 10:20

Gonals approved these changes Dec 13, 2024

View reviewed changes

Gonals merged commit b2dca65 into Expensify:main Dec 13, 2024
17 checks passed

github-actions bot mentioned this pull request Dec 13, 2024

Deploy Checklist: New Expensify 2024-12-13 #54111

Open

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: display all LHN options in Import state mode #53374

fix: display all LHN options in Import state mode #53374

TMisiukiewicz commented Dec 2, 2024

TMisiukiewicz commented Dec 2, 2024

melvin-bot bot commented Dec 11, 2024

TMisiukiewicz commented Dec 11, 2024

jjcoffee commented Dec 11, 2024 •

edited

Loading

jjcoffee commented Dec 11, 2024

This comment was marked as resolved.

jjcoffee left a comment

TMisiukiewicz commented Dec 13, 2024 •

edited

Loading

TMisiukiewicz commented Dec 13, 2024

jjcoffee left a comment

OSBotify commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

fix: display all LHN options in Import state mode #53374

fix: display all LHN options in Import state mode #53374

Conversation

TMisiukiewicz commented Dec 2, 2024

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

TMisiukiewicz commented Dec 2, 2024

melvin-bot bot commented Dec 11, 2024

TMisiukiewicz commented Dec 11, 2024

jjcoffee commented Dec 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Dec 11, 2024

This comment was marked as resolved.

jjcoffee left a comment

Choose a reason for hiding this comment

TMisiukiewicz commented Dec 13, 2024 • edited Loading

TMisiukiewicz commented Dec 13, 2024

jjcoffee left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

jjcoffee commented Dec 11, 2024 •

edited

Loading

TMisiukiewicz commented Dec 13, 2024 •

edited

Loading