-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update en.ts #54067
Update en.ts #54067
Conversation
Updating to match existing system message structure
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hopefully a quick one! (with Spanish) |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.0.76-0 🚀
|
@jamesdeanexpensify Is the action message suggested in the PR right? Testers are getting this message:
As a native Spanish speaker, I would say it's right, but I want to make sure with you. |
Yes, should be right. What makes you think it's wrong? Thanks! |
@jamesdeanexpensify because the suggested message in PR ( actualizó el nombre de este espacio de trabajo a (previamente ) ) refers to the name of a Workspace ("espacio de trabajo"), not a room (which seems fine in the testing, "sala"). Is that right? It should be "espacio de trabajo"? Thanks for answering |
Ah, I see what you mean. One action refers to room, one action refers to workspace - but they're both right. Thanks! |
Updating to match existing system message structure
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop