Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages to fix vulnerabilities #729

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Update packages to fix vulnerabilities #729

merged 2 commits into from
Jun 26, 2024

Conversation

pecanoro
Copy link
Contributor

The main dependency jest-environment-jsdom does not have any updates so I updated the package with npm update ws

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/407146

Tests

It's a dev dependency for tests so as long as tests are still passing, we should be good.

QA

N/A

@pecanoro pecanoro self-assigned this Jun 24, 2024
@pecanoro pecanoro requested a review from a team as a code owner June 24, 2024 20:41
@melvin-bot melvin-bot bot requested review from techievivek and removed request for a team June 24, 2024 20:41
@pecanoro
Copy link
Contributor Author

Snyk failed for no reason, not sure how to retrigger it, I am going to try merging with main

Copy link
Contributor

@techievivek techievivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. :shipit:

@techievivek techievivek merged commit e4bb1b2 into main Jun 26, 2024
6 checks passed
@techievivek techievivek deleted the rocio-WS branch June 26, 2024 07:09
Copy link

🚀Published to npm in v2.0.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants