From 941cfb4c5f9b83bdfa6cf47d278ed0d7f3eab04d Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Fri, 28 Jun 2024 12:14:07 +0800 Subject: [PATCH 1/2] dynamically update container height --- src/PDFPreviewer.tsx | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/PDFPreviewer.tsx b/src/PDFPreviewer.tsx index 126dfcc..292d142 100644 --- a/src/PDFPreviewer.tsx +++ b/src/PDFPreviewer.tsx @@ -231,8 +231,19 @@ function PDFPreviewer({ }, [isPasswordInvalid, attemptPDFLoad, setIsPasswordInvalid, renderPasswordForm]); useLayoutEffect(() => { - setContainerWidth(containerRef.current?.clientWidth ?? 0); - setContainerHeight(containerRef.current?.clientHeight ?? 0); + if (!containerRef.current) { + return; + } + const resizeObserver = new ResizeObserver(() => { + if (!containerRef.current) { + return; + } + setContainerWidth(containerRef.current.clientWidth); + setContainerHeight(containerRef.current.clientHeight); + }); + resizeObserver.observe(containerRef.current); + + return resizeObserver.disconnect; }, []); return ( From 403121de8baf6c32798a70c49178d2df44dee637 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 4 Jul 2024 11:14:55 +0800 Subject: [PATCH 2/2] fix lint --- src/PDFPreviewer.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/PDFPreviewer.tsx b/src/PDFPreviewer.tsx index 292d142..e810d23 100644 --- a/src/PDFPreviewer.tsx +++ b/src/PDFPreviewer.tsx @@ -232,7 +232,7 @@ function PDFPreviewer({ useLayoutEffect(() => { if (!containerRef.current) { - return; + return undefined; } const resizeObserver = new ResizeObserver(() => { if (!containerRef.current) { @@ -243,7 +243,7 @@ function PDFPreviewer({ }); resizeObserver.observe(containerRef.current); - return resizeObserver.disconnect; + return () => resizeObserver.disconnect(); }, []); return (