Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diacritics fix #210

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Diacritics fix #210

merged 6 commits into from
Mar 6, 2024

Conversation

BartoszGrajdek
Copy link
Collaborator

@BartoszGrajdek BartoszGrajdek commented Mar 4, 2024 •
edited
Loading

Details

This PR fixes diacritics not working on every browser

Related Issues

Expensify/App#36942

Manual Tests

  1. Try adding a diacritic in the text input i.e. Option+u and then "a" - this should result in "ä"
  2. You can now try different cases like doing it in nested blocks, at the beginning of a word, in the middle of it, or by itself.

Linked PRs

Skalakid
Skalakid previously approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BartoszGrajdek BartoszGrajdek requested a review from tomekzaw March 4, 2024 20:40
tomekzaw
tomekzaw reviewed Mar 5, 2024
View reviewed changes
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
src/MarkdownTextInput.web.tsx Outdated Show resolved Hide resolved
@BartoszGrajdek BartoszGrajdek requested a review from tomekzaw March 5, 2024 10:16
@tomekzaw
Copy link
Collaborator

tomekzaw commented Mar 5, 2024

There seems to be some problem with text color in this case:

Screen.Recording.2024-03-05.at.11.51.01.mov

@thienlnam thienlnam mentioned this pull request Mar 5, 2024
Closed
6 tasks
Skalakid
Skalakid requested changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Skalakid Skalakid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder color doesn't update when placeholderTextColor prop changes

Screen.Recording.2024-03-06.at.15.07.39.mov

@BartoszGrajdek
Copy link
Collaborator Author

Fixed @Skalakid

Skalakid
Skalakid previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@Skalakid Skalakid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tomekzaw
tomekzaw approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@BartoszGrajdek BartoszGrajdek merged commit 8504e9b into main Mar 6, 2024
2 checks passed
@BartoszGrajdek BartoszGrajdek deleted the diacritics-fix branch March 6, 2024 16:50
@sobitneupane sobitneupane mentioned this pull request Apr 29, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@Skalakid Skalakid Skalakid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BartoszGrajdek @tomekzaw @Skalakid