Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump expensify-common to 2.0.10 #360

Merged
merged 18 commits into from
Jun 7, 2024
Merged

Conversation

nkdengineer
Copy link
Contributor

Details

Bump new expensify-common version to fix the phone number mention for live-markdown preview

Related Issues

Expensify/App#41078

Manual Tests

Linked PRs

Expensify/expensify-common#697

@nkdengineer nkdengineer marked this pull request as ready for review June 3, 2024 05:10
parser/index.ts Outdated Show resolved Hide resolved
parser/patches/expensify-common+2.0.4.patch Outdated Show resolved Hide resolved
@tomekzaw tomekzaw changed the title bump expensify-common version Bump expensify-common version Jun 3, 2024
parser/package.json Outdated Show resolved Hide resolved
@blimpich
Copy link

blimpich commented Jun 5, 2024

@hungvu193 is this PR ready for internal engineer review other than the version bump specified here? Lets keep this PR moving 🏃‍♂️‍➡️ 🙂

@hungvu193
Copy link

@hungvu193 is this PR ready for internal engineer review other than the version bump specified here? Lets keep this PR moving 🏃‍♂️‍➡️ 🙂

All good. Just a comment left that you mentioned 😄

@tomekzaw tomekzaw changed the title Bump expensify-common version Bump expensify-common to 2.0.10 Jun 6, 2024
@tomekzaw
Copy link
Collaborator

tomekzaw commented Jun 6, 2024

I was able to eliminate expensify-common patch as well as remove patch-package from parser directory by using Babel (in particular, module:@react-native/babel-preset) to transpile the bundled file.

tomekzaw
tomekzaw previously approved these changes Jun 6, 2024
@tomekzaw tomekzaw merged commit 8c2111c into Expensify:main Jun 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants