Unable pasting photos and styled text #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Overall looks good 👍🏻
I still need to test it in the E/App - that's something I'll handle tomorrow. If @Skalakid has a moment it would be great if he tested the styled text case - I can't get it working even on the main 🤷🏻♂️
|
@BartoszGrajdek just keep in mind that in the E/App this error is possibly handled, as I tried to reproduce this case (at least with photos) there and I couldn't do it 😉 |
Skalakid
approved these changes
Jun 10, 2024
BartoszGrajdek
approved these changes
Jun 10, 2024
|
Once we fix current problems in the lib we'll merge this |
|
Hey, I just tested these changes in NewDot and there is a console error and the text gets pasted twice:
Screen.Recording.2024-07-05.at.13.35.39.mov |
61 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The default paste behaviour is overridden by inserting a `text/plain' value.