-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up configs and flows from Expensify repository template #123
Merged
Merged
Changes from 15 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e8ce644
introduce prettier/eslint configs and github flows from Expensify tem…
robertKozik d968cad
introduce prettier/eslint configs and github flows from Expensify tem…
robertKozik 014a4ad
introduce required changes to satisfy new eslint/prettier config
robertKozik 303aee8
change yarn to npm
robertKozik 9eaafec
add lib directory to .eslintignore file
robertKozik 8db340e
update lint github action to include installing WebExample dependencies
robertKozik 86c2e64
update name of the npm ci inside lint.yml action
robertKozik 23bc748
update eslint rules
robertKozik 8b56860
run prettier against all project files
robertKozik 849ad03
Merge branch 'main' into merge
robertKozik 1d0bcd8
revert back to yarn
robertKozik 2e7c5d2
Merge branch 'main' into merge-expensify-template
robertKozik d4cdddb
Merge branch 'main' into merge
robertKozik a450039
scope prettier/eslint/typecheck to source folder only - excluding exa…
robertKozik dfab75f
create separate lint calls for different subfolders & exclude them fr…
robertKozik a91ffb0
revert formatting of unwanted files
robertKozik bf74fbf
fix whitespaces
robertKozik d80746b
remove undwanted ts rules
robertKozik 7ee8adf
run lint across all dirs
robertKozik 166a927
Move Prettier setup to `.prettierrc.js`
tomekzaw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,18 @@ | ||
**/node_modules/* | ||
parser/react-native-live-markdown-parser.js | ||
|
||
# any js file inside android and ios folders | ||
**/android/**/*.js | ||
**/ios/**/*.js | ||
|
||
# Output of the build process & scripts | ||
lib/**/* | ||
scripts/**/* | ||
|
||
babel.config.js | ||
metro.config.js | ||
react-native.config.js | ||
jest.config.js | ||
webpack.config.js | ||
.eslintrc.js | ||
.prettierrc.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<!-- If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit. --> | ||
|
||
### Details | ||
<!-- Explanation of the change or anything fishy that is going on --> | ||
|
||
### Related Issues | ||
<!-- Please replace GH_LINK with the link to the GitHub issue this Pull Request is related to --> | ||
GH_LINK | ||
|
||
### Manual Tests | ||
<!--- | ||
Most changes should have accompanying tests. Describe the tests you added or if no tests were added an explanation about why one was not needed. | ||
---> | ||
|
||
### Linked PRs | ||
<!--- | ||
Please include links to any update PRs in repos that must change their package.json version. | ||
---> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: CLA Assistant | ||
|
||
on: | ||
issue_comment: | ||
types: [created] | ||
pull_request_target: | ||
types: [opened, closed, synchronize] | ||
|
||
jobs: | ||
CLA: | ||
runs-on: ubuntu-latest | ||
# This job only runs for pull request comments or pull request target events (not issue comments) | ||
if: github.event.issue.pull_request || github.event_name == 'pull_request_target' | ||
steps: | ||
- uses: actions-ecosystem/action-regex-match@9c35fe9ac1840239939c59e5db8839422eed8a73 | ||
id: sign | ||
with: | ||
text: ${{ github.event.comment.body }} | ||
regex: '\s*I have read the CLA Document and I hereby sign the CLA\s*' | ||
- uses: actions-ecosystem/action-regex-match@9c35fe9ac1840239939c59e5db8839422eed8a73 | ||
id: recheck | ||
with: | ||
text: ${{ github.event.comment.body }} | ||
regex: '\s*recheck\s*' | ||
- name: CLA Assistant | ||
if: ${{ steps.recheck.outputs.match != '' || steps.sign.outputs.match != '' }} || github.event_name == 'pull_request_target' | ||
# Version: 2.1.2-beta | ||
uses: cla-assistant/github-action@948230deb0d44dd38957592f08c6bd934d96d0cf | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
PERSONAL_ACCESS_TOKEN : ${{ secrets.CLA_BOTIFY_TOKEN }} | ||
with: | ||
path-to-signatures: '${{ github.repository }}/cla.json' | ||
path-to-document: 'https://github.com/${{ github.repository }}/blob/main/CLA.md' | ||
branch: 'main' | ||
remote-organization-name: 'Expensify' | ||
remote-repository-name: 'CLA' | ||
lock-pullrequest-aftermerge: false | ||
allowlist: 'snyk-bot,OSBotify' | ||
tomekzaw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: Lint JavaScript | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize] | ||
|
||
jobs: | ||
lint: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v2 | ||
|
||
- uses: actions/cache@v2 | ||
with: | ||
path: ~/.yarn | ||
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | ||
restore-keys: | | ||
${{ runner.os }}-yarn- | ||
|
||
- name: Setup Node | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: "16.x" | ||
|
||
- name: Setup web example | ||
run: npm ci | ||
working-directory: ./WebExample | ||
|
||
- run: yarn install --immutable | ||
|
||
|
||
- name: Verify there's no Prettier diff | ||
run: | | ||
yarn lint --fix --quiet | ||
if ! git diff --name-only --exit-code; then | ||
# shellcheck disable=SC2016 | ||
echo 'Error: Prettier diff detected! Please run `npm run prettier` and commit the changes.' | ||
exit 1 | ||
fi | ||
tomekzaw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
# name: Publish package to npmjs | ||
|
||
# # This workflow runs when code is pushed to `main` (i.e: when a pull request is merged) | ||
# on: | ||
# push: | ||
# branches: [main] | ||
|
||
# # Ensure that only once instance of this workflow executes at a time. | ||
# # If multiple PRs are merged in quick succession, there will only ever be one publish workflow running and one pending. | ||
# concurrency: ${{ github.workflow }} | ||
|
||
# jobs: | ||
# version: | ||
# runs-on: ubuntu-latest | ||
|
||
# # OSBotify will update the version on `main`, so this check is important to prevent an infinite loop | ||
# if: ${{ github.actor != 'OSBotify' }} | ||
|
||
# steps: | ||
# - uses: actions/checkout@v3 | ||
# with: | ||
# ref: main | ||
|
||
# - name: Decrypt & Import OSBotify GPG key | ||
# run: | | ||
# cd .github | ||
# gpg --quiet --batch --yes --decrypt --passphrase="$LARGE_SECRET_PASSPHRASE" --output OSBotify-private-key.asc OSBotify-private-key.asc.gpg | ||
# gpg --import OSBotify-private-key.asc | ||
# env: | ||
# LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} | ||
|
||
# - name: Set up git for OSBotify | ||
# run: | | ||
# git config --global user.signingkey 367811D53E34168C | ||
# git config --global commit.gpgsign true | ||
# git config --global user.name OSBotify | ||
# git config --global user.email [email protected] | ||
|
||
# - uses: actions/setup-node@v3 | ||
# with: | ||
# node-version: '16.x' | ||
# registry-url: 'https://registry.npmjs.org' | ||
|
||
# - name: Generate branch name | ||
# run: echo "BRANCH_NAME=OSBotify-bump-version-$(uuidgen)" >> $GITHUB_ENV | ||
|
||
# - name: Create branch for version-bump pull request | ||
# run: git checkout -b ${{ env.BRANCH_NAME }} | ||
|
||
# - name: Install npm packages | ||
# run: npm ci | ||
|
||
# - name: Update npm version | ||
# run: npm version patch | ||
|
||
# - name: Set new version in GitHub ENV | ||
# run: echo "NEW_VERSION=$(jq '.version' package.json)" >> $GITHUB_ENV | ||
|
||
# - name: Push branch and publish tags | ||
# run: git push --set-upstream origin ${{ env.BRANCH_NAME }} && git push --tags | ||
|
||
# - name: Create pull request | ||
# run: | | ||
# gh pr create \ | ||
# --title "Update version to ${{ env.NEW_VERSION }}" \ | ||
# --body "Update version to ${{ env.NEW_VERSION }}" | ||
# sleep 5 | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | ||
|
||
# - name: Auto-approve pull request | ||
# run: gh pr review --approve ${{ env.BRANCH_NAME }} | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# - name: Auto-merge pull request | ||
# run: gh pr merge --merge --delete-branch ${{ env.BRANCH_NAME }} | ||
# env: | ||
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# - name: Build package | ||
# run: npm run build | ||
|
||
# - name: Publish to npm | ||
# run: npm publish | ||
# env: | ||
# NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
tomekzaw marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
{} | ||
{} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.