Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacing default element in undo history #348

Merged
merged 3 commits into from
May 20, 2024

Conversation

Skalakid
Copy link
Collaborator

@Skalakid Skalakid commented May 16, 2024

Details

This PR fixes the bug when pasting text into composer before the page fully loads and the default history item is replaced

Related Issues

Expensify/App#39255

Manual Tests

Note

Issues are mostly reproducible in E/App

Unable to undo pasted text issue

  1. Reload the app
  2. Paste text quickly into auto-focused markdown input
  3. Undo it by clicking Ctrl + Z
  4. Verify if the text was undone and if you can redo the changes

Wrong history index after repeating paste and undo

  1. Open the app
  2. Paste text into
  3. Undo it by clicking Ctrl + Z
  4. Paste text into
  5. Undo it by clicking Ctrl + Z, verify if the text was undone
  6. Go to step 2 and repeat

Linked PRs

#342

@Skalakid Skalakid requested a review from BartoszGrajdek May 16, 2024 08:56
@Skalakid Skalakid marked this pull request as draft May 16, 2024 10:13
@Skalakid Skalakid self-assigned this May 16, 2024
@Skalakid Skalakid marked this pull request as ready for review May 16, 2024 12:31
@Skalakid Skalakid merged commit c59787e into main May 20, 2024
4 checks passed
@Skalakid Skalakid deleted the @Skalakid/fix-replacing-first-element-in-history branch May 20, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants