-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement code and pre blocks support on web #456
base: main
Are you sure you want to change the base?
Implement code and pre blocks support on web #456
Conversation
4584a62
to
c57b91f
Compare
Some check are failing, please take a look at them 👀 Also, I found some problems with code block background positioning when pasting the block next to other markdowns and the issue with disappearing newline after first backticks: Screen.Recording.2024-10-16.at.11.40.50.movScreen.Recording.2024-10-16.at.11.42.01.mov |
There are some problems with cursor positioning. After reloading the page, when I click after the third backtick, you can see how the cursor position is being moved to the line below. Screen.Recording.2024-10-17.at.16.53.00.mov |
Also please fix E2E tests connected to inline code and code blocks |
I'll do that once we pass all manual tests - they are failing mainly due to inline styles being different which can change when adding fixes. As for the cursor positioning issue I'll look into it tomorrow 👀 |
Added fixes @Skalakid |
Okay, thank you. All reported issues are fixed. However, now I found that the background width in changing when writing outside the codeblock... Screen.Recording.2024-10-29.at.12.28.20.mov |
Fixed! @Skalakid |
Found couple of new bugs: bug.1.movbug.2.mov |
Found two smaller issues:
Screen.Recording.2024-12-12.at.12.40.34.mov
Screen.Recording.2024-12-12.at.12.45.15.mov |
Details
Related Issues
GH_LINK
Manual Tests
Change codeFance rule in
/node_modules/expensify-common/dist/ExpensiMark.js
to code belowLinked PRs