Merge pull request #92 from kidroca/kidroca/perf-set-avoid-duplicates

perf: Skip a write to storage when nothing is actually changing
Expensify · Jul 29, 2021 · d73900b · d73900b
2 parents 61e6888 + 908ec0a
commit d73900b
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/Onyx.js b/lib/Onyx.js
@@ -527,6 +527,11 @@ function evictStorageAndRetry(error, ionMethod, ...args) {
  * @returns {Promise}
  */
 function set(key, val) {
+    // Skip writing to storage if the value hasn't changed
+    if (cache.hasCacheForKey(key) && _.isEqual(val, cache.getValue(key))) {
+        return Promise.resolve();
+    }
+
     // Adds the key to cache when it's not available
     cache.set(key, val);