From d7471893a3692dd4403d32a0a7fab6de9885db45 Mon Sep 17 00:00:00 2001 From: Pedro Guerreiro Date: Tue, 29 Aug 2023 17:28:03 +0100 Subject: [PATCH 1/3] feat: bump node version to 18.17.1 --- .github/workflows/lint.yml | 2 +- .github/workflows/publish.yml | 2 +- .github/workflows/test.yml | 2 +- .nvmrc | 2 +- package-lock.json | 4 ++-- package.json | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index e178d885..6e8f2988 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -13,7 +13,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v3 with: - node-version: "16.x" + node-version-file: ".nvmrc" cache: npm cache-dependency-path: package-lock.json diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 08bc9e44..3b695232 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -38,7 +38,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: '16.x' + node-version-file: '.nvmrc' registry-url: 'https://registry.npmjs.org' - name: Generate branch name diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 2c79ac75..1fc2ffa7 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,7 +20,7 @@ jobs: - name: Setup Node uses: actions/setup-node@v1 with: - node-version: "16.x" + node-version-file: '.nvmrc' - run: npm ci diff --git a/.nvmrc b/.nvmrc index b8c9fdcb..7ec56198 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -16.15.1 \ No newline at end of file +18.17.1 \ No newline at end of file diff --git a/package-lock.json b/package-lock.json index 204233a4..ba053f80 100644 --- a/package-lock.json +++ b/package-lock.json @@ -47,8 +47,8 @@ "webpack-merge": "^5.8.0" }, "engines": { - "node": "16.15.1", - "npm": "8.11.0" + "node": "18.17.1", + "npm": "9.6.7" }, "peerDependencies": { "idb-keyval": "^6.2.1", diff --git a/package.json b/package.json index 05781107..8d1ea931 100644 --- a/package.json +++ b/package.json @@ -100,8 +100,8 @@ } }, "engines": { - "node": "16.15.1", - "npm": "8.11.0" + "node": "18.17.1", + "npm": "9.6.7" }, "jest": { "preset": "react-native", From 1a4f0f3f3e9a375d48833f79d7f3a262b266b574 Mon Sep 17 00:00:00 2001 From: Pedro Guerreiro <48553277+pac-guerreiro@users.noreply.github.com> Date: Wed, 30 Aug 2023 11:59:47 +0100 Subject: [PATCH 2/3] chore: update node and npm version range to be compatible with expensify app MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Fábio Henriques --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 8d1ea931..2f1683eb 100644 --- a/package.json +++ b/package.json @@ -100,8 +100,8 @@ } }, "engines": { - "node": "18.17.1", - "npm": "9.6.7" + "node": ">=16.15.1 <=18.17.1", + "npm": ">=8.11.0 <=9.6.7" }, "jest": { "preset": "react-native", From dd842e9b922be6819c7a381e2e44528ea43ec2ff Mon Sep 17 00:00:00 2001 From: Pedro Guerreiro Date: Thu, 5 Oct 2023 18:07:29 +0100 Subject: [PATCH 3/3] chore(github): bump setup-node version from v1 to v3 --- .github/workflows/test.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 1fc2ffa7..51e3aaa5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -18,9 +18,9 @@ jobs: ${{ runner.os }}-node- - name: Setup Node - uses: actions/setup-node@v1 + uses: actions/setup-node@v3 with: - node-version-file: '.nvmrc' + node-version-file: ".nvmrc" - run: npm ci